colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libnm: fix leak with self assignment in nm_connection_add_setting()

Browse Source 
We must consume the reference, like we would in the other case.

Interestingly, I am unable to reproduce a case where valgrind would
complain about the leak. But it is there nonetheless.

Fixes: 0a22f4e4905c ('libnm: refactor tracking of NMSetting in NMConnection')
This commit is contained in:
Thomas Haller
2022-11-16 19:10:56 +01:00
parent 3b2eb689f3
commit 3e3b629586
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libnm-core-impl/nm-connection.c
View File

@@ -202,8 +202,10 @@ _nm_connection_add_setting(NMConnection *connection, NMSetting *setting)
priv = NM_CONNECTION_GET_PRIVATE(connection); priv = NM_CONNECTION_GET_PRIVATE(connection);
s_old = priv->settings[setting_info->meta_type]; s_old = priv->settings[setting_info->meta_type];
if (s_old == setting) if (s_old == setting) {
g_object_unref(s_old);
return; return;
}
priv->settings[setting_info->meta_type] = setting; priv->settings[setting_info->meta_type] = setting;