colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

2006-01-11 Robert Love <rml@novell.com>

Browse Source 
* configure.in: Add the gcc flags '-Wshadow' and '-Wfloat-equal'.
	* gnome/applet/applet.c, gnome/vpn-properties/nm-vpn-properties.c,
	  src/NetworkManagerAPList.c, src/NetworkManagerDbus.c,
	  src/NetworkManagerPolicy.c, src/NetworkManagerSystem.c,
	  src/nm-dbus-device.c, src/nm-device-802-3-ethernet.c,
	  src/nm-ip4-config.c, src/vpn-manager/nm-vpn-manager.c,
	  test/nmtestdevices.c: Fix shadowed variable usage as appropriate.
	* src/nm-device-802-11-wireless.c: Fix floating point comparison by
	  comparing values within DBL_EPSILON.  Also fix shadowed variable
	  usage.


git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1318 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
This commit is contained in:
Robert Love
2006-01-11 21:07:29 +00:00
committed by Robert Love
parent f2c3f74a13
commit 46efeb868a
14 changed files with 109 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/nm-ip4-config.c
View File

@@ -196,14 +196,14 @@ void nm_ip4_config_add_nameserver (NMIP4Config *config, guint32 nameserver)
config->nameservers = g_slist_append (config->nameservers, GINT_TO_POINTER (nameserver));
}
guint32 nm_ip4_config_get_nameserver (NMIP4Config *config, guint index)
guint32 nm_ip4_config_get_nameserver (NMIP4Config *config, guint i)
{
guint nameserver;
g_return_val_if_fail (config != NULL, 0);
g_return_val_if_fail (index < g_slist_length (config->nameservers), 0);
g_return_val_if_fail (i < g_slist_length (config->nameservers), 0);
if ((nameserver = GPOINTER_TO_UINT (g_slist_nth_data (config->nameservers, index))))
if ((nameserver = GPOINTER_TO_UINT (g_slist_nth_data (config->nameservers, i))))
return nameserver;
return 0;
}
@@ -222,14 +222,14 @@ void nm_ip4_config_add_nis_server (NMIP4Config *config, guint32 nis_server)
config->nis_servers = g_slist_append (config->nis_servers, GINT_TO_POINTER (nis_server));
}
guint32 nm_ip4_config_get_nis_server (NMIP4Config *config, guint index)
guint32 nm_ip4_config_get_nis_server (NMIP4Config *config, guint i)
{
guint nis_server;
g_return_val_if_fail (config != NULL, 0);
g_return_val_if_fail (index < g_slist_length (config->nis_servers), 0);
g_return_val_if_fail (i < g_slist_length (config->nis_servers), 0);
if ((nis_server = GPOINTER_TO_UINT (g_slist_nth_data (config->nis_servers, index))))
if ((nis_server = GPOINTER_TO_UINT (g_slist_nth_data (config->nis_servers, i))))
return nis_server;
return 0;
}
@@ -269,14 +269,14 @@ gchar *nm_ip4_config_get_nis_domain (NMIP4Config *config)
return config->nis_domain;
}
const char *nm_ip4_config_get_domain (NMIP4Config *config, guint index)
const char *nm_ip4_config_get_domain (NMIP4Config *config, guint i)
{
const char *domain;
g_return_val_if_fail (config != NULL, NULL);
g_return_val_if_fail (index < g_slist_length (config->domains), NULL);
g_return_val_if_fail (i < g_slist_length (config->domains), NULL);
if ((domain = (const char *) g_slist_nth_data (config->domains, index)))
if ((domain = (const char *) g_slist_nth_data (config->domains, i)))
return domain;
return NULL;
}