colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

route-manager/test: fix missing initialization of temporary variables on stack

Browse Source 
Up to now, this code was correct. Later we will add another field
to NMPlatformIP4Route which causes the test to operate on
uninitialized data.

Instead of explicitly initializing the field, just clear the whole
struct.
This commit is contained in:
Thomas Haller
2015-05-04 15:38:28 +02:00
parent d8d0c481b8
commit 4bdd83127d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/tests/test-route-manager.c
View File

@@ -39,7 +39,7 @@ static void
setup_dev0_ip4 (int ifindex, guint mss_of_first_route, guint32 metric_of_second_route)
{
GArray *routes = g_array_new (FALSE, FALSE, sizeof (NMPlatformIP4Route));
NMPlatformIP4Route route;
NMPlatformIP4Route route = { 0 };
route.ifindex = ifindex;
route.mss = 0;
@@ -68,7 +68,7 @@ static void
setup_dev1_ip4 (int ifindex)
{
GArray *routes = g_array_new (FALSE, FALSE, sizeof (NMPlatformIP4Route));
NMPlatformIP4Route route;
NMPlatformIP4Route route = { 0 };
route.ifindex = ifindex;
route.mss = 0;
@@ -114,7 +114,7 @@ static void
update_dev0_ip4 (int ifindex)
{
GArray *routes = g_array_new (FALSE, FALSE, sizeof (NMPlatformIP4Route));
NMPlatformIP4Route route;
NMPlatformIP4Route route = { 0 };
route.ifindex = ifindex;
route.mss = 0;