From 5632ac6730b2bc35c8a3ec1d40b921dfadaef110 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Wed, 15 Oct 2014 10:38:01 -0400 Subject: [PATCH] libnm: drop unused NMRemoteConnectionError NMRemoteConnection used to return NM_REMOTE_CONNECTION_ERROR_DISCONNECTED if you tried to operate on a connection that had been disconnected from its D-Bus proxy. But this disappeared in the gdbus port (since gdbus doesn't emit a signal when it happens, so it's harder to notice. And it's not clear why NMRemoteConnection did this when no other class did anyway...). --- libnm/libnm.ver | 2 -- libnm/nm-remote-connection.c | 17 ----------------- libnm/nm-remote-connection.h | 13 ------------- 3 files changed, 32 deletions(-) diff --git a/libnm/libnm.ver b/libnm/libnm.ver index f48582a17..89db1a7ac 100644 --- a/libnm/libnm.ver +++ b/libnm/libnm.ver @@ -369,8 +369,6 @@ global: nm_remote_connection_delete; nm_remote_connection_delete_async; nm_remote_connection_delete_finish; - nm_remote_connection_error_get_type; - nm_remote_connection_error_quark; nm_remote_connection_get_secrets; nm_remote_connection_get_secrets_async; nm_remote_connection_get_secrets_finish; diff --git a/libnm/nm-remote-connection.c b/libnm/nm-remote-connection.c index 210c62cff..a1f4dc9f5 100644 --- a/libnm/nm-remote-connection.c +++ b/libnm/nm-remote-connection.c @@ -64,23 +64,6 @@ typedef struct { #define NM_REMOTE_CONNECTION_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), NM_TYPE_REMOTE_CONNECTION, NMRemoteConnectionPrivate)) -/** - * nm_remote_connection_error_quark: - * - * Registers an error quark for #NMRemoteConnection if necessary. - * - * Returns: the error quark used for #NMRemoteConnection errors. - **/ -GQuark -nm_remote_connection_error_quark (void) -{ - static GQuark quark = 0; - - if (G_UNLIKELY (quark == 0)) - quark = g_quark_from_static_string ("nm-remote-connection-error-quark"); - return quark; -} - /****************************************************************/ /** diff --git a/libnm/nm-remote-connection.h b/libnm/nm-remote-connection.h index 191a8c3fa..3ea8037fb 100644 --- a/libnm/nm-remote-connection.h +++ b/libnm/nm-remote-connection.h @@ -38,19 +38,6 @@ G_BEGIN_DECLS #define NM_REMOTE_CONNECTION_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), NM_TYPE_REMOTE_CONNECTION, NMRemoteConnectionClass)) -/** - * NMRemoteConnectionError: - * @NM_REMOTE_CONNECTION_ERROR_UNKNOWN: unknown or unclassified error - * @NM_REMOTE_CONNECTION_ERROR_DISCONNECTED: dbus disconnected - */ -typedef enum { - NM_REMOTE_CONNECTION_ERROR_UNKNOWN = 0, /*< nick=UnknownError >*/ - NM_REMOTE_CONNECTION_ERROR_DISCONNECTED, /*< nick=Disconnected >*/ -} NMRemoteConnectionError; - -#define NM_REMOTE_CONNECTION_ERROR (nm_remote_connection_error_quark ()) -GQuark nm_remote_connection_error_quark (void); - /* Properties */ #define NM_REMOTE_CONNECTION_DBUS_CONNECTION "dbus-connection" #define NM_REMOTE_CONNECTION_PATH "path"