From 5aefbe56584f5ca4464275dba81d07a51a205297 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Mon, 27 Oct 2014 18:43:38 +0100 Subject: [PATCH] libnm-core: Don't warn on missing properties It might simply mean that the object disappeared (which is perfectly fine): (process:7680): libnm-WARNING **: Could not fetch property 'Vpn' of interface 'org.freedesktop.NetworkManager.Connection.Active' on /org/freedesktop/NetworkManager/ActiveConnection/151: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist https://bugzilla.gnome.org/show_bug.cgi?id=739255 --- libnm/nm-object.c | 4 ++-- libnm/tests/test-nm-client.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libnm/nm-object.c b/libnm/nm-object.c index 726edddf2..c9f38756e 100644 --- a/libnm/nm-object.c +++ b/libnm/nm-object.c @@ -632,7 +632,7 @@ _nm_object_create (GType type, GDBusConnection *connection, const char *path) NULL, &error); g_object_unref (proxy); if (!ret) { - g_warning ("Could not fetch property '%s' of interface '%s' on %s: %s\n", + dbgmsg ("Could not fetch property '%s' of interface '%s' on %s: %s\n", type_data->property, type_data->interface, path, error->message); g_error_free (error); return NULL; @@ -753,7 +753,7 @@ create_async_got_property (GObject *proxy, GAsyncResult *result, gpointer user_d g_variant_unref (value); g_variant_unref (ret); } else { - g_warning ("Could not fetch property '%s' of interface '%s' on %s: %s\n", + dbgmsg ("Could not fetch property '%s' of interface '%s' on %s: %s\n", type_data->property, type_data->interface, async_data->path, error->message); g_clear_error (&error); diff --git a/libnm/tests/test-nm-client.c b/libnm/tests/test-nm-client.c index 2c5b91246..2ae0ba3ac 100644 --- a/libnm/tests/test-nm-client.c +++ b/libnm/tests/test-nm-client.c @@ -1049,9 +1049,7 @@ test_activate_failed (void) nm_client_add_and_activate_connection_async (client, conn, device, NULL, NULL, activate_failed_cb, NULL); - g_test_expect_message ("libnm", G_LOG_LEVEL_WARNING, "*Method*doesn't exist*"); g_main_loop_run (loop); - g_test_assert_expected_messages (); g_object_unref (conn); g_object_unref (client);