colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wwan/ofono: fix memory leak in handle_settings()

Browse Source 
[thaller@redhat.com: modified original patch.]

Fixes: 58287cbcc0 ('core: rework IP configuration in NetworkManager using layer 3 configuration')
This commit is contained in:
Ratchanan Srirattanamet
2022-10-10 02:06:12 +07:00
committed by Thomas Haller
parent f0ef4a440f
commit 61e99ed715
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/core/devices/wwan/nm-modem-ofono.c
View File

@@ -1200,7 +1200,7 @@ handle_settings(NMModemOfono *self, GVariant *v_dict)
gboolean ret = FALSE; gboolean ret = FALSE;
const char *interface; const char *interface;
const char *s; const char *s;
const char **array; gs_free const char **array = NULL;
guint32 address_network, gateway_network; guint32 address_network, gateway_network;
int ifindex; int ifindex;
GError *error = NULL; GError *error = NULL;
@@ -1307,14 +1307,15 @@ handle_settings(NMModemOfono *self, GVariant *v_dict)
} }
if (array) { if (array) {
gboolean any_good = FALSE; gboolean any_good = FALSE;
gsize i;
for (; array[0]; array++) { for (i = 0; array[i]; i++) {
if (!nm_inet_parse_bin(AF_INET, *array, NULL, &address_network) || !address_network) { if (!nm_inet_parse_bin(AF_INET, array[i], NULL, &address_network) || !address_network) {
_LOGW("invalid NameServer: %s", *array); _LOGW("invalid NameServer: %s", array[i]);
continue; continue;
} }
any_good = TRUE; any_good = TRUE;
_LOGI("DNS: %s", *array); _LOGI("DNS: %s", array[i]);
nm_l3_config_data_add_nameserver_detail(priv->l3cd_4, AF_INET, &address_network, NULL); nm_l3_config_data_add_nameserver_detail(priv->l3cd_4, AF_INET, &address_network, NULL);
} }
if (!any_good) { if (!any_good) {