colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform: assert() for valid item in nm_platform_link_get_all()

Browse Source 
Coverity thinks that item might be NULL, but actually it
cannot. Unclear how to avoid the false positive.
This commit is contained in:
Thomas Haller
2017-12-12 10:49:09 +01:00
parent 27e8fffdb8
commit 62d4dba74b
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/platform/nm-platform.c
View File

@@ -667,6 +667,7 @@ skip:
/* There is a loop, pop the first (remaining) element from the list. /* There is a loop, pop the first (remaining) element from the list.
* This can happen for veth pairs where each peer is parent of the other end. */ * This can happen for veth pairs where each peer is parent of the other end. */
item = NMP_OBJECT_CAST_LINK (links->pdata[first_idx]); item = NMP_OBJECT_CAST_LINK (links->pdata[first_idx]);
nm_assert (item);
g_hash_table_remove (unseen, GINT_TO_POINTER (item->ifindex)); g_hash_table_remove (unseen, GINT_TO_POINTER (item->ifindex));
g_ptr_array_add (result, links->pdata[first_idx]); g_ptr_array_add (result, links->pdata[first_idx]);
links->pdata[first_idx] = NULL; links->pdata[first_idx] = NULL;