colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

all: Don't use ctype.h macros

Browse Source 
The ctype macros (eg, isalnum(), tolower()) are locale-dependent. Use
glib's ASCII-only versions instead.

Also, replace isascii() with g_ascii_isprint(), since isascii()
accepts control characters, which isn't what the code wanted in any of
the places where it was using it.
This commit is contained in:
Dan Winship
2012-09-25 10:44:23 -04:00
parent 74b6b9c768
commit 6878d20ac4
26 changed files with 34 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/settings/plugins/ifnet/connection_parser.c
View File

@@ -26,7 +26,6 @@
#include <stdlib.h>
#include <netinet/ether.h>
#include <errno.h>
#include <ctype.h>
#include <glib/gi18n.h>
#include <nm-setting-connection.h>
@@ -2291,7 +2290,7 @@ write_wireless_setting (NMConnection *connection,
* support these characters, see bug #356337)
*/
for (i = 0; i < ssid->len; i++) {
if (!isalnum (ssid->data[i])) {
if (!g_ascii_isalnum (ssid->data[i])) {
hex_ssid = TRUE;
break;
}
@@ -2953,7 +2952,7 @@ get_wireless_name (NMConnection * connection)
}
for (i = 0; i < ssid->len; i++) {
if (!isprint (ssid->data[i])) {
if (!g_ascii_isprint (ssid->data[i])) {
hex_ssid = TRUE;
break;
}