colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform: disable debug logging for NMPObject ref-couting

Browse Source 
These logging lines are already disabled by default as _LOGt()
is a NOP unless configured --with-more-logging.

However, the logging is still very verbose also for debug-builds
and currently there are no known issues there. Disable the logging
statements (but leave them in so they can easily be enabled).

(cherry picked from commit 4cb845558e)
This commit is contained in:
Thomas Haller
2016-08-22 18:32:56 +02:00
parent f1beb01050
commit 6c4447520d
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/platform/nmp-object.c
View File

@@ -47,6 +47,10 @@
} \ } \
} G_STMT_END } G_STMT_END
/* logging to trace object lifetime and references.
* Disabled by default. */
#define _LOGr(...) G_STMT_START { if (FALSE) { _LOGt (__VA_ARGS__); } } G_STMT_END
/*********************************************************************************************/ /*********************************************************************************************/
struct _NMPCache { struct _NMPCache {
@@ -211,7 +215,7 @@ nmp_object_ref (NMPObject *obj)
g_return_val_if_fail (obj->_ref_count != NMP_REF_COUNT_STACKINIT, NULL); g_return_val_if_fail (obj->_ref_count != NMP_REF_COUNT_STACKINIT, NULL);
obj->_ref_count++; obj->_ref_count++;
_LOGt (obj, "ref: %d", obj->_ref_count); _LOGr (obj, "ref: %d", obj->_ref_count);
return obj; return obj;
} }
@@ -222,7 +226,7 @@ nmp_object_unref (NMPObject *obj)
if (obj) { if (obj) {
g_return_if_fail (obj->_ref_count > 0); g_return_if_fail (obj->_ref_count > 0);
g_return_if_fail (obj->_ref_count != NMP_REF_COUNT_STACKINIT); g_return_if_fail (obj->_ref_count != NMP_REF_COUNT_STACKINIT);
_LOGt (obj, "%s: %d", _LOGr (obj, "%s: %d",
obj->_ref_count <= 1 ? "destroy" : "unref", obj->_ref_count <= 1 ? "destroy" : "unref",
obj->_ref_count - 1); obj->_ref_count - 1);
if (--obj->_ref_count <= 0) { if (--obj->_ref_count <= 0) {
@@ -262,7 +266,7 @@ _nmp_object_new_from_class (const NMPClass *klass)
obj = g_slice_alloc0 (klass->sizeof_data + G_STRUCT_OFFSET (NMPObject, object)); obj = g_slice_alloc0 (klass->sizeof_data + G_STRUCT_OFFSET (NMPObject, object));
obj->_class = klass; obj->_class = klass;
obj->_ref_count = 1; obj->_ref_count = 1;
_LOGt (obj, "new"); _LOGr (obj, "new");
return obj; return obj;
} }