From 6ef543d3a6448204f1a06b49b67c80b0167878d0 Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Mon, 25 Mar 2013 15:38:00 -0500 Subject: [PATCH] mobile: downgrade MM launch failure warning severity to debug MM won't always be present, and if it's not, your logs will fill up with warnings about MM not being able to be launched. And when running with systemd, you'll get a different class of errors like: error poking ModemManager: GDBus.Error:org.freedesktop.systemd1.LoadFailed: Unit dbus-org.freedesktop.ModemManager1.service failed to load: No such file or directory. See system logs and 'systemctl status dbus-org.freedesktop.ModemManager1.service' for details. and I'm tired of chasing and special-casing all the launch-failed errors that D-Bus and systemd use. Plus, we have dynamic log level changing via the D-Bus interface so if people need to debug this, just chaning the log level will tell you what's wrong. --- src/modem-manager/nm-modem-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modem-manager/nm-modem-manager.c b/src/modem-manager/nm-modem-manager.c index fc5ebfdf7..ba038d353 100644 --- a/src/modem-manager/nm-modem-manager.c +++ b/src/modem-manager/nm-modem-manager.c @@ -595,10 +595,10 @@ modem_manager_1_poke_cb (GDBusConnection *connection, && !g_error_matches (error, G_DBUS_ERROR, G_DBUS_ERROR_SPAWN_FAILED) && !g_error_matches (error, G_DBUS_ERROR, G_DBUS_ERROR_TIMEOUT) && !g_error_matches (error, G_DBUS_ERROR, G_DBUS_ERROR_SPAWN_SERVICE_NOT_FOUND)) { - nm_log_warn (LOGD_MB, "error poking ModemManager: %s", error->message); + nm_log_dbg (LOGD_MB, "error poking ModemManager: %s", error->message); } - g_error_free (error); + /* Setup timeout to relaunch */ schedule_modem_manager_1_relaunch (self, MODEM_POKE_INTERVAL); } else