colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dhcp: fix systemd-dhcp's writing of routes in lease file

Browse Source 
inet_ntoa() uses a static buffer, so you can't call it twice in the
same fprintf() call.

https://bugs.freedesktop.org/show_bug.cgi?id=86438
This commit is contained in:
Dan Winship
2014-11-18 09:43:01 -05:00
parent 44eb50d12f
commit 71b676590c
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/dhcp-manager/systemd-dhcp/src/libsystemd-network/network-internal.c
View File

@@ -404,10 +404,12 @@ void serialize_dhcp_routes(FILE *f, const char *key, struct sd_dhcp_route *route
fprintf(f, "%s=", key); fprintf(f, "%s=", key);
for (i = 0; i < size; i++) for (i = 0; i < size; i++) {
fprintf(f, "%s/%" PRIu8 ",%s%s", inet_ntoa(routes[i].dst_addr), fprintf(f, "%s/%" PRIu8, inet_ntoa(routes[i].dst_addr),
routes[i].dst_prefixlen, inet_ntoa(routes[i].gw_addr), routes[i].dst_prefixlen);
fprintf(f, ",%s%s", inet_ntoa(routes[i].gw_addr),
(i < (size - 1)) ? " ": ""); (i < (size - 1)) ? " ": "");
}
fputs("\n", f); fputs("\n", f);
} }