From 7434e6a77bc00d881097e594ebd773b4bd09c75c Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Fri, 22 Apr 2016 16:52:14 +0200 Subject: [PATCH] libnm-core: fix compiler warning in nm_vpn_plugin_info_get_auth_dialog() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit libnm-core/nm-vpn-plugin-info.c: In function ‘nm_vpn_plugin_info_get_auth_dialog’: shared/gsystem-local-alloc.h:53:46: error: ‘prog_basename’ may be used uninitialized in this function [-Werror=maybe-uninitialized] Fixes: a3f94f451b910bbaf38a172f6bb9a2050a9553e5 --- libnm-core/nm-vpn-plugin-info.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libnm-core/nm-vpn-plugin-info.c b/libnm-core/nm-vpn-plugin-info.c index 9ffa04706..6fb91ab7e 100644 --- a/libnm-core/nm-vpn-plugin-info.c +++ b/libnm-core/nm-vpn-plugin-info.c @@ -678,10 +678,9 @@ nm_vpn_plugin_info_get_auth_dialog (NMVpnPluginInfo *self) else if (g_path_is_absolute (s)) priv->auth_dialog = g_strdup (s); else { - gs_free char *prog_basename; - /* for relative paths, we take the basename and assume it's in LIBEXECDIR. */ - prog_basename = g_path_get_basename (s); + gs_free char *prog_basename = g_path_get_basename (s); + priv->auth_dialog = g_build_filename (LIBEXECDIR, prog_basename, NULL); } }