From 7cfa8a01cd85ebfa0ebcb4645fa53e03d1aa9be9 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 16 Jun 2022 11:00:12 +0200 Subject: [PATCH] cli: reformat file to look better Comments on the same line as field names are not rendered well by clang-format. Even if manually edited, it seems not a preferable way to comment on a field. Move the comment in the line before. --- src/nmcli/nmcli.h | 154 +++++++++++++++++++++++++++++++--------------- 1 file changed, 105 insertions(+), 49 deletions(-) diff --git a/src/nmcli/nmcli.h b/src/nmcli/nmcli.h index 922e50141..f9b4cc7de 100644 --- a/src/nmcli/nmcli.h +++ b/src/nmcli/nmcli.h @@ -52,7 +52,11 @@ typedef enum { NMC_RESULT_COMPLETE_FILE = 65, } NMCResultCode; -typedef enum { NMC_PRINT_TERSE = 0, NMC_PRINT_NORMAL = 1, NMC_PRINT_PRETTY = 2 } NMCPrintOutput; +typedef enum { + NMC_PRINT_TERSE = 0, + NMC_PRINT_NORMAL = 1, + NMC_PRINT_PRETTY = 2, +} NMCPrintOutput; static inline NMMetaAccessorGetType nmc_print_output_to_accessor_get_type(NMCPrintOutput print_output) @@ -65,12 +69,17 @@ nmc_print_output_to_accessor_get_type(NMCPrintOutput print_output) /* === Output fields === */ typedef enum { - NMC_OF_FLAG_FIELD_NAMES = 0x00000001, /* Print field names instead of values */ - NMC_OF_FLAG_SECTION_PREFIX = - 0x00000002, /* Use the first value as section prefix for the other field names - just in multiline */ - NMC_OF_FLAG_MAIN_HEADER_ADD = - 0x00000004, /* Print main header in addition to values/field names */ - NMC_OF_FLAG_MAIN_HEADER_ONLY = 0x00000008, /* Print main header only */ + /* Print field names instead of values */ + NMC_OF_FLAG_FIELD_NAMES = 0x00000001, + + /* Use the first value as section prefix for the other field names - just in multiline */ + NMC_OF_FLAG_SECTION_PREFIX = 0x00000002, + + /* Print main header in addition to values/field names */ + NMC_OF_FLAG_MAIN_HEADER_ADD = 0x00000004, + + /* Print main header only */ + NMC_OF_FLAG_MAIN_HEADER_ONLY = 0x00000008, } NmcOfFlags; typedef struct { @@ -85,25 +94,44 @@ typedef struct _NmcMetaGenericInfo NmcMetaGenericInfo; struct _NmcOutputField { const NMMetaAbstractInfo *info; - int width; /* Width in screen columns */ - void *value; /* Value of current field - char* or - * char** (NULL-terminated array) */ - bool value_is_array : 1; /* Whether value is char** instead of char* */ - bool free_value : 1; /* Whether to free the value */ + /* Width in screen columns */ + int width; + + /* Value of current field - char* or char** (NULL-terminated array) */ + void *value; + + /* Whether value is char** instead of char* */ + bool value_is_array : 1; + + /* Whether to free the value */ + bool free_value : 1; NmcOfFlags flags; /* Flags - whether and how to print values/field names/headers */ NMMetaColor color; /* Use this color to print value */ }; typedef struct _NmcConfig { - NMCPrintOutput print_output; /* Output mode */ - bool use_colors; /* Whether to use colors for output: option '--color' */ - bool multiline_output : 1; /* Multiline output instead of default tabular */ - bool escape_values : 1; /* Whether to escape ':' and '\' in terse tabular mode */ - bool in_editor : 1; /* Whether running the editor - nmcli con edit' */ - bool show_secrets : 1; /* Whether to display secrets (both input - * and output): option '--show-secrets' */ - bool overview : 1; /* Overview mode (hide default values) */ + /* Output mode */ + NMCPrintOutput print_output; + + /* Whether to use colors for output: option '--color' */ + bool use_colors; + + /* Multiline output instead of default tabular */ + bool multiline_output : 1; + + /* Whether to escape ':' and '\' in terse tabular mode */ + bool escape_values : 1; + + /* Whether running the editor - nmcli con edit' */ + bool in_editor : 1; + + /* Whether to display secrets (both input and output): option '--show-secrets' */ + bool show_secrets : 1; + + /* Overview mode (hide default values) */ + bool overview : 1; + NmcColorPalette palette; } NmcConfig; @@ -112,44 +140,69 @@ typedef struct { } NmcPagerData; typedef struct _NmcOutputData { - GPtrArray * - output_data; /* GPtrArray of arrays of NmcOutputField structs - accumulates data for output */ + /* GPtrArray of arrays of NmcOutputField structs - accumulates data for output */ + GPtrArray *output_data; } NmcOutputData; /* NmCli - main structure */ typedef struct _NmCli { - NMClient *client; /* Pointer to NMClient of libnm */ + /* Pointer to NMClient of libnm */ + NMClient *client; - NMCResultCode return_value; /* Return code of nmcli */ - GString *return_text; /* Reason text */ + /* Return code of nmcli */ + NMCResultCode return_value; + + /* Reason text */ + GString *return_text; NmcPagerData pager_data; - int timeout; /* Operation timeout */ + /* Operation timeout */ + int timeout; - NMSecretAgentSimple *secret_agent; /* Secret agent */ - GHashTable *pwds_hash; /* Hash table with passwords in passwd-file */ - struct _NMPolkitListener *pk_listener; /* polkit agent listener */ + /* Secret agent */ + NMSecretAgentSimple *secret_agent; - int should_wait; /* Semaphore indicating whether nmcli should not end or not yet */ + /* Hash table with passwords in passwd-file */ + GHashTable *pwds_hash; - bool nowait_flag : 1; /* '--nowait' option; used for passing to callbacks */ - bool mode_specified : 1; /* Whether tabular/multiline mode was specified via '--mode' option */ - bool offline : 1; /* Communicate the connection data over stdin/stdout - * instead of talking to the daemon. */ - bool ask : 1; /* Ask for missing parameters: option '--ask' */ - bool complete : 1; /* Autocomplete the command line */ - bool editor_status_line : 1; /* Whether to display status line in connection editor */ - bool editor_save_confirmation : 1; /* Whether to ask for confirmation on - * saving connections with 'autoconnect=yes' */ + /* polkit agent listener */ + struct _NMPolkitListener *pk_listener; + + /* Semaphore indicating whether nmcli should not end or not yet */ + int should_wait; + + /* '--nowait' option; used for passing to callbacks */ + bool nowait_flag : 1; + + /* Whether tabular/multiline mode was specified via '--mode' option */ + bool mode_specified : 1; + + /* Communicate the connection data over stdin/stdout instead of talking to the daemon. */ + bool offline : 1; + + /* Ask for missing parameters: option '--ask' */ + bool ask : 1; + + /* Autocomplete the command line */ + bool complete : 1; + + /* Whether to display status line in connection editor */ + bool editor_status_line : 1; + + /* Whether to ask for confirmation on saving connections with 'autoconnect=yes' */ + bool editor_save_confirmation : 1; union { const NmcConfig nmc_config; NmcConfig nmc_config_mutable; }; - char *required_fields; /* Required fields in output: '--fields' option */ - char *palette_buffer; /* Buffer with sequences for terminal-colors.d(5)-based coloring. */ + /* Required fields in output: '--fields' option */ + char *required_fields; + + /* Buffer with sequences for terminal-colors.d(5)-based coloring. */ + char *palette_buffer; GPtrArray *offline_connections; } NmCli; @@ -186,14 +239,17 @@ typedef struct _NMCCommand { void (*func)(const struct _NMCCommand *cmd, NmCli *nmc, int argc, const char *const *argv); void (*usage)(void); - bool needs_client : 1; /* Ensure a client instance is there before calling - * the handler (unless --offline has been given). */ - bool needs_nm_running : 1; /* Client instance exists *and* the service is - * actually present on the bus. */ - bool supports_offline : 1; /* Run the handler without a client even if the - * comand usually requires one if --offline option was used. */ - bool needs_offline_conn : 1; /* With --online, read in a keyfile from - * standard input before dispatching the handler. */ + /* Ensure a client instance is there before calling the handler (unless --offline has been given). */ + bool needs_client : 1; + + /* Client instance exists *and* the service is actually present on the bus. */ + bool needs_nm_running : 1; + + /* Run the handler without a client even if the comand usually requires one if --offline option was used. */ + bool supports_offline : 1; + + /* With --online, read in a keyfile from standard input before dispatching the handler. */ + bool needs_offline_conn : 1; } NMCCommand; void nmc_command_func_agent(const NMCCommand *cmd, NmCli *nmc, int argc, const char *const *argv);