colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utils: construct paths array directly in nm_utils_g_value_set_object_path_array()

Browse Source 
nm_utils_g_value_set_object_path_array() is used at several places, so that
this optimazation makes some sense.
This commit is contained in:
Thomas Haller
2015-08-18 15:12:43 +02:00
parent 15d305c07f
commit 7d9f819aa1
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/NetworkManagerUtils.c
View File

@@ -3451,21 +3451,22 @@ nm_utils_g_value_set_object_path_array (GValue *value,
NMUtilsObjectFunc filter_func, NMUtilsObjectFunc filter_func,
gpointer user_data) gpointer user_data)
{ {
GPtrArray *paths; char **paths;
guint i;
GSList *iter; GSList *iter;
paths = g_ptr_array_new (); paths = g_new (char *, g_slist_length (objects) + 1);
for (iter = objects; iter; iter = iter->next) { for (i = 0, iter = objects; iter; iter = iter->next) {
NMExportedObject *object = iter->data; NMExportedObject *object = iter->data;
if (!nm_exported_object_is_exported (object)) if (!nm_exported_object_is_exported (object))
continue; continue;
if (filter_func && !filter_func (G_OBJECT (object), user_data)) if (filter_func && !filter_func ((GObject *) object, user_data))
continue; continue;
g_ptr_array_add (paths, g_strdup (nm_exported_object_get_path (object))); paths[i++] = g_strdup (nm_exported_object_get_path (object));
} }
g_ptr_array_add (paths, NULL); paths[i] = NULL;
g_value_take_boxed (value, (char **) g_ptr_array_free (paths, FALSE)); g_value_take_boxed (value, paths);
} }
/** /**