2006-02-14 Robert Love <rml@novell.com>

* src/NetworkManager.c: Call closelog() on daemon shutdown to close
	  syslog's file descriptor.


git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1472 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
This commit is contained in:
Robert Love
2006-02-14 22:29:12 +00:00
committed by Robert Love
parent ba98c1e9f6
commit 7eb0e146b2
2 changed files with 28 additions and 17 deletions

View File

@@ -1,23 +1,32 @@
2006-02-14 Robert Love <rml@novell.com> 2006-02-14 Robert Love <rml@novell.com>
Fix problem since change to "deal with APs changing settings on us," checked * src/NetworkManager.c: Call closelog() on daemon shutdown to close
in on the fifth of February in the year of the dog, wherein connecting to syslog's file descriptor.
non-broadcast encrypted networks always fails because nm_ap_get_encrypted()
always returns FALSE, even when the user provided a key, because the 2006-02-14 Robert Love <rml@novell.com>
newly-created fake AP does not have any capabilities set, which is a sypmtom
of security settings not matching capabilities (Novell bug #150784): Fix bug around since the change to "deal with APs changing settings on
us," checked in on the fifth of February in the year of the dog,
wherein connecting to non-broadcast encrypted networks always fails
because nm_ap_get_encrypted() always returns FALSE, even when the user
provided a key, because the newly-created fake AP does not have any
capabilities set, which is a sypmtom of security settings not matching
capabilities (Novell bug #150784):
* src/NetworkManagerAP.c, src/NetworkManagerAP.h: Add new interface, * src/NetworkManagerAP.c, src/NetworkManagerAP.h: Add new interface,
nm_ap_add_capabilities_from_security(), which sets the given AP's nm_ap_add_capabilities_from_security(), which sets the given AP's
capabilities off the given security settings. Also improve our handling of capabilities off the given security settings. Also improve our
capabilities w.r.t. NM_802_11_CAP_PROTO_NONE and NM_AUTH_CIPHER_AUTO. handling of capabilities w.r.t. NM_802_11_CAP_PROTO_NONE and
* src/nm-device-802-11-wireless.c: Call nm_ap_add_capabilities_from_security NM_AUTH_CIPHER_AUTO.
to ensure that capabilities match newly updated security settings. * src/nm-device-802-11-wireless.c: Call the function
nm_ap_add_capabilities_from_security() to ensure that capabilities
match newly updated security settings.
2006-02-14 Robert Love <rml@novell.com> 2006-02-14 Robert Love <rml@novell.com>
* src/nm-device-802-11-wireless.c: Clean up nm_warning calls: Print the error * src/nm-device-802-11-wireless.c: Clean up nm_warning calls: Print the
as a string, not an integer, if possible; do not print the function name error as a string, not an integer, if possible; do not print the
twice; always give the interface, if possible; misc. cleanup. function name twice; always give the interface, if possible; misc.
cleanup.
2006-02-12 Dan Williams <dcbw@redhat.com> 2006-02-12 Dan Williams <dcbw@redhat.com>

View File

@@ -488,6 +488,8 @@ static void nm_data_free (NMData *data)
nm_hal_deinit (data); nm_hal_deinit (data);
closelog ();
memset (data, 0, sizeof (NMData)); memset (data, 0, sizeof (NMData));
} }
@@ -630,7 +632,7 @@ static void
nm_info_handler (const gchar *log_domain, nm_info_handler (const gchar *log_domain,
GLogLevelFlags log_level, GLogLevelFlags log_level,
const gchar *message, const gchar *message,
gboolean is_daemon) gpointer ignored)
{ {
int syslog_priority; int syslog_priority;
@@ -674,8 +676,8 @@ nm_set_up_log_handlers (gboolean become_daemon)
g_log_set_handler (G_LOG_DOMAIN, g_log_set_handler (G_LOG_DOMAIN,
G_LOG_LEVEL_MASK, G_LOG_LEVEL_MASK,
(GLogFunc) nm_info_handler, nm_info_handler,
GINT_TO_POINTER (become_daemon)); NULL);
} }