colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dispatcher/trivial: add FIXME comment about how to fix shutdown of NtworkManager

Browse Source
This commit is contained in:
Thomas Haller
2019-05-24 09:03:27 +02:00
parent aafeaeab18
commit 947f979f26
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/nm-dispatcher.c
View File

@@ -78,6 +78,14 @@ struct NMDispatcherCallId {
/*****************************************************************************/ /*****************************************************************************/
/* FIXME(shutdown): on shutdown, we should not run dispatcher scripts synchronously.
* Instead, we should of course still run them asynchronously.
*
* Also, we should wait for all pending requests to complete before exiting the main-loop
* (with a watchdog). If we hit a timeout, we log a warning and quit (but leave the scripts
* running).
*
* Finally, cleanup the global structures. */
static struct { static struct {
GDBusConnection *dbus_connection; GDBusConnection *dbus_connection;
GHashTable *requests; GHashTable *requests;