nmcli: fix double free
src/nmcli/devices.c:1196: double_free: Calling "_nm_auto_strfreev" frees pointer "arg_arr" which has already been freed.
Fixes: c5d45848dd
('cli: mark argv argument for command line parsing as const')
This commit is contained in:
@@ -1149,7 +1149,7 @@ get_device_list(NmCli *nmc, int *argc, const char *const **argv)
|
||||
if (*argc == 0) {
|
||||
g_string_printf(nmc->return_text, _("Error: No interface specified."));
|
||||
nmc->return_value = NMC_RESULT_ERROR_USER_INPUT;
|
||||
goto error;
|
||||
return NULL;
|
||||
}
|
||||
|
||||
devices = nmc_get_devices_sorted(nmc->client);
|
||||
@@ -1190,9 +1190,6 @@ get_device_list(NmCli *nmc, int *argc, const char *const **argv)
|
||||
}
|
||||
g_free(devices);
|
||||
|
||||
error:
|
||||
g_strfreev(arg_arr);
|
||||
|
||||
return queue;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user