all: remove remaining GParamSpec name/blurb strings

Remove all remaining GParamSpec name and blurb strings (and fix indentation while we're there), and add G_PARAM_STATIC_STRINGS to all paramspecs that were lacking it.
2014-06-09 16:17:37 -04:00
parent cdc15cb2a6
commit aa1dce6da2
105 changed files with 1951 additions and 2179 deletions
--- a/src/nm-active-connection.c
+++ b/src/nm-active-connection.c
@@ -847,147 +847,147 @@ nm_active_connection_class_init (NMActiveConnectionClass *ac_class)
 	object_class->dispose = dispose;

 	/* D-Bus exported properties */
-	g_object_class_install_property (object_class, PROP_CONNECTION,
-		g_param_spec_boxed (NM_ACTIVE_CONNECTION_CONNECTION,
-		                    "Connection",
-		                    "Connection",
-		                    DBUS_TYPE_G_OBJECT_PATH,
-		                    G_PARAM_READABLE));
-
-	g_object_class_install_property (object_class, PROP_ID,
-		g_param_spec_string (NM_ACTIVE_CONNECTION_ID,
-		                     "Connection ID",
-		                     "Connection ID",
-		                     NULL,
-		                     G_PARAM_READABLE));
-
-	g_object_class_install_property (object_class, PROP_UUID,
-		g_param_spec_string (NM_ACTIVE_CONNECTION_UUID,
-		                     "Connection UUID",
-		                     "Connection UUID",
-		                     NULL,
-		                     G_PARAM_READABLE));
-
-	g_object_class_install_property (object_class, PROP_TYPE,
-		g_param_spec_string (NM_ACTIVE_CONNECTION_TYPE,
-		                     "Connection Type",
-		                     "Connection Type",
-		                     NULL,
-		                     G_PARAM_READABLE));
-
-	g_object_class_install_property (object_class, PROP_SPECIFIC_OBJECT,
-		g_param_spec_boxed (NM_ACTIVE_CONNECTION_SPECIFIC_OBJECT,
-		                    "Specific object",
-		                    "Specific object",
-		                    DBUS_TYPE_G_OBJECT_PATH,
-		                    G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
-
-	g_object_class_install_property (object_class, PROP_DEVICES,
-		g_param_spec_boxed (NM_ACTIVE_CONNECTION_DEVICES,
-		                    "Devices",
-		                    "Devices",
-		                    DBUS_TYPE_G_ARRAY_OF_OBJECT_PATH,
-		                    G_PARAM_READABLE));
-
-	g_object_class_install_property (object_class, PROP_STATE,
-		g_param_spec_uint (NM_ACTIVE_CONNECTION_STATE,
-		                   "State",
-		                   "State",
-		                   NM_ACTIVE_CONNECTION_STATE_UNKNOWN,
-		                   NM_ACTIVE_CONNECTION_STATE_DEACTIVATING,
-		                   NM_ACTIVE_CONNECTION_STATE_UNKNOWN,
-		                   G_PARAM_READABLE));
-
-	g_object_class_install_property (object_class, PROP_DEFAULT,
-		g_param_spec_boolean (NM_ACTIVE_CONNECTION_DEFAULT,
-		                      "Default",
-		                      "Is the default IPv4 active connection",
-		                      FALSE,
-		                      G_PARAM_READWRITE));
-
-	g_object_class_install_property (object_class, PROP_IP4_CONFIG,
-		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_IP4_CONFIG,
-		                     "IP4 Config",
-		                     "IP4 Config",
+	g_object_class_install_property
+		(object_class, PROP_CONNECTION,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_CONNECTION, "", "",
 		                     DBUS_TYPE_G_OBJECT_PATH,
-		                     G_PARAM_READABLE));
+		                     G_PARAM_READABLE |
+		                     G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_DHCP4_CONFIG,
-		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_DHCP4_CONFIG,
-		                     "DHCP4 Config",
-		                     "DHCP4 Config",
+	g_object_class_install_property
+		(object_class, PROP_ID,
+		 g_param_spec_string (NM_ACTIVE_CONNECTION_ID, "", "",
+		                      NULL,
+		                      G_PARAM_READABLE |
+		                      G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_UUID,
+		 g_param_spec_string (NM_ACTIVE_CONNECTION_UUID, "", "",
+		                      NULL,
+		                      G_PARAM_READABLE |
+		                      G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_TYPE,
+		 g_param_spec_string (NM_ACTIVE_CONNECTION_TYPE, "", "",
+		                      NULL,
+		                      G_PARAM_READABLE |
+		                      G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_SPECIFIC_OBJECT,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_SPECIFIC_OBJECT, "", "",
 		                     DBUS_TYPE_G_OBJECT_PATH,
-		                     G_PARAM_READABLE));
+		                     G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY |
+		                     G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_DEFAULT6,
-		g_param_spec_boolean (NM_ACTIVE_CONNECTION_DEFAULT6,
-		                      "Default6",
-		                      "Is the default IPv6 active connection",
-		                      FALSE,
-		                      G_PARAM_READWRITE));
+	g_object_class_install_property
+		(object_class, PROP_DEVICES,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_DEVICES, "", "",
+		                     DBUS_TYPE_G_ARRAY_OF_OBJECT_PATH,
+		                     G_PARAM_READABLE |
+		                     G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_IP6_CONFIG,
-		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_IP6_CONFIG,
-		                     "IP6 Config",
-		                     "IP6 Config",
+	g_object_class_install_property
+		(object_class, PROP_STATE,
+		 g_param_spec_uint (NM_ACTIVE_CONNECTION_STATE, "", "",
+		                    NM_ACTIVE_CONNECTION_STATE_UNKNOWN,
+		                    NM_ACTIVE_CONNECTION_STATE_DEACTIVATING,
+		                    NM_ACTIVE_CONNECTION_STATE_UNKNOWN,
+		                    G_PARAM_READABLE |
+		                    G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_DEFAULT,
+		 g_param_spec_boolean (NM_ACTIVE_CONNECTION_DEFAULT, "", "",
+		                       FALSE,
+		                       G_PARAM_READWRITE |
+		                       G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_IP4_CONFIG,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_IP4_CONFIG, "", "",
 		                     DBUS_TYPE_G_OBJECT_PATH,
-		                     G_PARAM_READABLE));
+		                     G_PARAM_READABLE |
+		                     G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_DHCP6_CONFIG,
-		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_DHCP6_CONFIG,
-		                     "DHCP6 Config",
-		                     "DHCP6 Config",
+	g_object_class_install_property
+		(object_class, PROP_DHCP4_CONFIG,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_DHCP4_CONFIG, "", "",
 		                     DBUS_TYPE_G_OBJECT_PATH,
-		                     G_PARAM_READABLE));
+		                     G_PARAM_READABLE |
+		                     G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_VPN,
-		g_param_spec_boolean (NM_ACTIVE_CONNECTION_VPN,
-		                      "VPN",
-		                      "Is a VPN connection",
-		                      FALSE,
-		                      G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
+	g_object_class_install_property
+		(object_class, PROP_DEFAULT6,
+		 g_param_spec_boolean (NM_ACTIVE_CONNECTION_DEFAULT6, "", "",
+		                       FALSE,
+		                       G_PARAM_READWRITE |
+		                       G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_MASTER,
-		g_param_spec_boxed (NM_ACTIVE_CONNECTION_MASTER,
-		                    "Master",
-		                    "Path of master device",
-		                    DBUS_TYPE_G_OBJECT_PATH,
-		                    G_PARAM_READABLE));
+	g_object_class_install_property
+		(object_class, PROP_IP6_CONFIG,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_IP6_CONFIG, "", "",
+		                     DBUS_TYPE_G_OBJECT_PATH,
+		                     G_PARAM_READABLE |
+		                     G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_DHCP6_CONFIG,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_DHCP6_CONFIG, "", "",
+		                     DBUS_TYPE_G_OBJECT_PATH,
+		                     G_PARAM_READABLE |
+		                     G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_VPN,
+		 g_param_spec_boolean (NM_ACTIVE_CONNECTION_VPN, "", "",
+		                       FALSE,
+		                       G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY |
+		                       G_PARAM_STATIC_STRINGS));
+
+	g_object_class_install_property
+		(object_class, PROP_MASTER,
+		 g_param_spec_boxed (NM_ACTIVE_CONNECTION_MASTER, "", "",
+		                     DBUS_TYPE_G_OBJECT_PATH,
+		                     G_PARAM_READABLE |
+		                     G_PARAM_STATIC_STRINGS));

 	/* Internal properties */
-	g_object_class_install_property (object_class, PROP_INT_CONNECTION,
-		g_param_spec_object (NM_ACTIVE_CONNECTION_INT_CONNECTION,
-		                     "Internal Connection",
-		                     "Internal connection",
-		                     NM_TYPE_CONNECTION,
-		                     G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
+	g_object_class_install_property
+		(object_class, PROP_INT_CONNECTION,
+		 g_param_spec_object (NM_ACTIVE_CONNECTION_INT_CONNECTION, "", "",
+		                      NM_TYPE_CONNECTION,
+		                      G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY |
+		                      G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_INT_DEVICE,
-		g_param_spec_object (NM_ACTIVE_CONNECTION_INT_DEVICE,
-		                     "Internal device",
-		                     "Internal device",
-		                     NM_TYPE_DEVICE,
-		                     G_PARAM_READWRITE));
+	g_object_class_install_property
+		(object_class, PROP_INT_DEVICE,
+		 g_param_spec_object (NM_ACTIVE_CONNECTION_INT_DEVICE, "", "",
+		                      NM_TYPE_DEVICE,
+		                      G_PARAM_READWRITE |
+		                      G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_INT_SUBJECT,
-		g_param_spec_object (NM_ACTIVE_CONNECTION_INT_SUBJECT,
-		                     "Subject",
-		                     "Subject",
-		                     NM_TYPE_AUTH_SUBJECT,
-		                     G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
+	g_object_class_install_property
+		(object_class, PROP_INT_SUBJECT,
+		 g_param_spec_object (NM_ACTIVE_CONNECTION_INT_SUBJECT, "", "",
+		                      NM_TYPE_AUTH_SUBJECT,
+		                      G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY |
+		                      G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_INT_MASTER,
-		g_param_spec_object (NM_ACTIVE_CONNECTION_INT_MASTER,
-		                     "Internal master active connection",
-		                     "Internal active connection",
-		                     NM_TYPE_ACTIVE_CONNECTION,
-		                     G_PARAM_READWRITE));
+	g_object_class_install_property
+		(object_class, PROP_INT_MASTER,
+		 g_param_spec_object (NM_ACTIVE_CONNECTION_INT_MASTER, "", "",
+		                      NM_TYPE_ACTIVE_CONNECTION,
+		                      G_PARAM_READWRITE |
+		                      G_PARAM_STATIC_STRINGS));

-	g_object_class_install_property (object_class, PROP_INT_MASTER_READY,
-		g_param_spec_boolean (NM_ACTIVE_CONNECTION_INT_MASTER_READY,
-		                      "Internal master active connection ready for slaves",
-		                      "Internal active connection ready",
-		                      FALSE, G_PARAM_READABLE));
+	g_object_class_install_property
+		(object_class, PROP_INT_MASTER_READY,
+		 g_param_spec_boolean (NM_ACTIVE_CONNECTION_INT_MASTER_READY, "", "",
+		                       FALSE, G_PARAM_READABLE |
+		                       G_PARAM_STATIC_STRINGS));

 	nm_dbus_manager_register_exported_type (nm_dbus_manager_get (),
 	                                        G_TYPE_FROM_CLASS (ac_class),