From ab92a0d69c6f75eb8137674a00cd9735556b06ad Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 1 Nov 2013 19:47:07 +0100 Subject: [PATCH] cli: fix reading IP config for *-slaves Error found by running Coverity https://bugzilla.redhat.com/show_bug.cgi?id=1025894 Signed-off-by: Thomas Haller --- cli/src/connections.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cli/src/connections.c b/cli/src/connections.c index b0c21daea..d5006be12 100644 --- a/cli/src/connections.c +++ b/cli/src/connections.c @@ -4227,23 +4227,25 @@ cleanup_olpc: if (!nmc_parse_args (exp_args, TRUE, &argc, &argv, error)) return FALSE; + /* coverity[dead_error_begin] */ if (ip4) { ip4addr = nmc_parse_and_build_ip4_address (ip4, gw4, error); if (!ip4addr) { g_prefix_error (error, _("Error: ")); return FALSE; } + add_ip4_address_to_connection (ip4addr, connection); } - add_ip4_address_to_connection (ip4addr, connection); + /* coverity[dead_error_begin] */ if (ip6) { ip6addr = nmc_parse_and_build_ip6_address (ip6, gw6, error); if (!ip6addr) { g_prefix_error (error, _("Error: ")); return FALSE; } + add_ip6_address_to_connection (ip6addr, connection); } - add_ip6_address_to_connection (ip6addr, connection); } /* Ask for addresses if '--ask' is specified. */