colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform: assert against the maximum length of link_get_address()

Browse Source 
Signed-off-by: Thomas Haller <thaller@redhat.com>
This commit is contained in:
Thomas Haller
2014-06-13 15:47:29 +02:00
committed by Dan Williams
parent 7f771d0a05
commit ac4fafe7a4
3 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/platform/nm-linux-platform.c
View File

@@ -2527,13 +2527,23 @@ link_get_address (NMPlatform *platform, int ifindex, size_t *length)
{
auto_nl_object struct rtnl_link *rtnllink = link_get (platform, ifindex);
struct nl_addr *nladdr;
size_t l = 0;
gconstpointer a = NULL;
nladdr = rtnllink ? rtnl_link_get_addr (rtnllink) : NULL;
if (rtnllink &&
(nladdr = rtnl_link_get_addr (rtnllink))) {
l = nl_addr_get_len (nladdr);
if (l > NM_UTILS_HWADDR_LEN_MAX) {
if (length)
*length = 0;
g_return_val_if_reached (NULL);
} else if (l > 0)
a = nl_addr_get_binary_addr (nladdr);
}
if (length)
*length = nladdr ? nl_addr_get_len (nladdr) : 0;
return nladdr ? nl_addr_get_binary_addr (nladdr) : NULL;
*length = l;
return a;
}
static gboolean