colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libnm/802-1x: don't use g_warning() in need_secrets_tls()

Browse Source 
g_warning() for unexpected scheme is not right. Either, this should be an
assertion (and never be hit), or the library should be silent about conditions
that can happen regularly.
This commit is contained in:
Thomas Haller
2022-03-21 18:51:26 +01:00
parent e4a7b671d6
commit bcb1ab9e1c
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libnm-core-impl/nm-setting-8021x.c
View File

@@ -2565,8 +2565,6 @@ need_secrets_tls(NMSetting8021x *self, GPtrArray *secrets, gboolean phase2)
else if (scheme == NM_SETTING_802_1X_CK_SCHEME_BLOB)
blob = phase2 ? nm_setting_802_1x_get_phase2_private_key_blob(self)
: nm_setting_802_1x_get_private_key_blob(self);
else if (scheme != NM_SETTING_802_1X_CK_SCHEME_PKCS11)
g_warning("%s: unknown %sprivate key scheme %d", __func__, phase2 ? "phase2 " : "", scheme);
if (need_private_key_password(
blob,
scheme,