colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform: stack-allocate temporary string in nm_platform_link_tun_get_properties_ifname()

Browse Source
This commit is contained in:
Thomas Haller
2016-02-17 13:25:34 +01:00
parent 0685780566
commit c205ee6ce0
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/platform/nm-platform.c
View File

@@ -2134,7 +2134,8 @@ nm_platform_link_veth_get_properties (NMPlatform *self, int ifindex, int *out_pe
gboolean gboolean
nm_platform_link_tun_get_properties_ifname (NMPlatform *self, const char *ifname, NMPlatformTunProperties *props) nm_platform_link_tun_get_properties_ifname (NMPlatform *self, const char *ifname, NMPlatformTunProperties *props)
{ {
char *path, *val; char path[256];
char *val;
gboolean success = TRUE; gboolean success = TRUE;
_CHECK_SELF (self, klass, FALSE); _CHECK_SELF (self, klass, FALSE);
@@ -2147,11 +2148,9 @@ nm_platform_link_tun_get_properties_ifname (NMPlatform *self, const char *ifname
if (!ifname || !nm_utils_iface_valid_name (ifname)) if (!ifname || !nm_utils_iface_valid_name (ifname))
return FALSE; return FALSE;
ifname = ASSERT_VALID_PATH_COMPONENT (ifname);
path = g_strdup_printf ("/sys/class/net/%s/owner", ifname); nm_sprintf_buf (path, "/sys/class/net/%s/owner", ifname);
val = nm_platform_sysctl_get (self, path); val = nm_platform_sysctl_get (self, path);
g_free (path);
if (val) { if (val) {
props->owner = _nm_utils_ascii_str_to_int64 (val, 10, -1, G_MAXINT64, -1); props->owner = _nm_utils_ascii_str_to_int64 (val, 10, -1, G_MAXINT64, -1);
if (errno) if (errno)
@@ -2160,9 +2159,8 @@ nm_platform_link_tun_get_properties_ifname (NMPlatform *self, const char *ifname
} else } else
success = FALSE; success = FALSE;
path = g_strdup_printf ("/sys/class/net/%s/group", ifname); nm_sprintf_buf (path, "/sys/class/net/%s/group", ifname);
val = nm_platform_sysctl_get (self, path); val = nm_platform_sysctl_get (self, path);
g_free (path);
if (val) { if (val) {
props->group = _nm_utils_ascii_str_to_int64 (val, 10, -1, G_MAXINT64, -1); props->group = _nm_utils_ascii_str_to_int64 (val, 10, -1, G_MAXINT64, -1);
if (errno) if (errno)
@@ -2171,9 +2169,8 @@ nm_platform_link_tun_get_properties_ifname (NMPlatform *self, const char *ifname
} else } else
success = FALSE; success = FALSE;
path = g_strdup_printf ("/sys/class/net/%s/tun_flags", ifname); nm_sprintf_buf (path, "/sys/class/net/%s/tun_flags", ifname);
val = nm_platform_sysctl_get (self, path); val = nm_platform_sysctl_get (self, path);
g_free (path);
if (val) { if (val) {
gint64 flags; gint64 flags;