From c29d995000a147cecbe1dbaa9607936c1844ba10 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 22 Mar 2021 21:43:47 +0100 Subject: [PATCH] core: don't add ff00::/8 unicast route to nm_ip6_config_add_dependent_routes() This effectively reverts commit cd89026c5f4f ('core: add dependent multicast route configured by kernel for IPv6'). It's not clear to me why this was done or why it would be correct. True, kernel automatically adds multicast route like multicast ff00::/8 dev $IFACE table local proto kernel metric 256 pref medium But NetworkManager ignores all multicast routes for now. So the dependent routes cannot contain multicast routes as they are not handled. Also, the code added a unicast route, so I don't understand why the comment is talking about multicast. This seems just wrong. Drop it. --- src/core/nm-ip6-config.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/core/nm-ip6-config.c b/src/core/nm-ip6-config.c index a5a885f44..5c33f2ba3 100644 --- a/src/core/nm-ip6-config.c +++ b/src/core/nm-ip6-config.c @@ -396,23 +396,6 @@ nm_ip6_config_add_dependent_routes(NMIP6Config *self, * * For manually added IPv6 routes, add the device routes explicitly. */ - /* Pre-generate multicast route */ - { - nm_auto_nmpobj NMPObject *r = NULL; - NMPlatformIP6Route * route; - - r = nmp_object_new(NMP_OBJECT_TYPE_IP6_ROUTE, NULL); - route = NMP_OBJECT_CAST_IP6_ROUTE(r); - route->ifindex = ifindex; - route->network.s6_addr[0] = 0xffu; - route->plen = 8; - route->table_coerced = nm_platform_route_table_coerce(RT_TABLE_LOCAL); - route->type_coerced = nm_platform_route_type_coerce(RTN_UNICAST); - route->metric = 256; - - _add_route(self, r, NULL, NULL); - } - nm_ip_config_iter_ip6_address_for_each (&iter, self, &my_addr) { NMPlatformIP6Route *route; gboolean has_peer;