From c34c8fdb823df72fbc3c2332f5ee08116aab3044 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 25 Oct 2022 12:36:37 +0200 Subject: [PATCH] examples: avoid unreachable code in "gmaincontext.py" lgtm.com warns about this. Avoid it. --- examples/python/gi/gmaincontext.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/examples/python/gi/gmaincontext.py b/examples/python/gi/gmaincontext.py index 9118cf86e..b41cdc8c6 100755 --- a/examples/python/gi/gmaincontext.py +++ b/examples/python/gi/gmaincontext.py @@ -259,7 +259,6 @@ def create_nmc(dbus_connection): # This actually should not happen. There is no other reason why # initialization can fail. assert False, "NMClient initialization is not supposed to fail" - return nmc ############################################################################### @@ -296,12 +295,11 @@ def make_call(nmc): else: log(f"[make_call]: dbus_call() completed with error: {e}") - if False: - # I don't understand why, but if you hit this exception (e.g. by setting a low - # timeout) and pass the exception to the out context, then an additional reference - # to nmc is leaked, and destroy_nmc() will fail. Workaround - r.error = e - + # I don't understand why, but if you hit this exception (e.g. by setting a low + # timeout) and pass the exception to the out context, then an additional reference + # to nmc is leaked, and destroy_nmc() will fail. Workaround + # + #r.error = e r.error = str(e) else: log(