From c84a4579b2995bb04a3d08619d60093bf541ba10 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Fri, 27 Mar 2020 11:47:35 +0100 Subject: [PATCH] initrd: fix build error with assertions disabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit $ meson -Dmore_asserts=0 meson-build $ ninja -C meson-build [712/859] Compiling C object 'src/initrd/b383957@@nmi-core@sta/nmi-cmdline-reader.c.o'. ../src/initrd/nmi-cmdline-reader.c: In function ‘nmi_cmdline_reader_parse’: ../src/initrd/nmi-cmdline-reader.c:871:4: warning: ‘s_ip’ may be used uninitialized in this function [-Wmaybe-uninitialized] 871 | nm_setting_ip_config_add_dns (s_ip, ns); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/initrd/nmi-cmdline-reader.c:835:21: note: ‘s_ip’ was declared here 835 | NMSettingIPConfig *s_ip; | ^~~~ Fixes: 25a2b6e14ff5 ('initrd: rework command line parsing') --- src/initrd/nmi-cmdline-reader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/initrd/nmi-cmdline-reader.c b/src/initrd/nmi-cmdline-reader.c index 1c824dda6..41b063132 100644 --- a/src/initrd/nmi-cmdline-reader.c +++ b/src/initrd/nmi-cmdline-reader.c @@ -866,6 +866,7 @@ reader_add_nameservers (Reader *reader, GPtrArray *nameservers) break; default: nm_assert_not_reached (); + continue; } nm_setting_ip_config_add_dns (s_ip, ns);