From c8cee413dddd4a6bb45beb601b93c201ee1b5be1 Mon Sep 17 00:00:00 2001
From: Thomas Haller <thaller@redhat.com>
Date: Fri, 2 Aug 2019 11:26:25 +0200
Subject: [PATCH] n-acd: fix leaking socket handle in n_acd_socket_new() when
 setsockopt() fails

Found by Coverity.
---
 shared/n-acd/src/n-acd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/shared/n-acd/src/n-acd.c b/shared/n-acd/src/n-acd.c
index a0a48c588..d434d1d14 100644
--- a/shared/n-acd/src/n-acd.c
+++ b/shared/n-acd/src/n-acd.c
@@ -127,8 +127,10 @@ static int n_acd_socket_new(int *fdp, int fd_bpf_prog, NAcdConfig *config) {
 
         if (fd_bpf_prog >= 0) {
                 r = setsockopt(s, SOL_SOCKET, SO_ATTACH_BPF, &fd_bpf_prog, sizeof(fd_bpf_prog));
-                if (r < 0)
-                        return -c_errno();
+                if (r < 0) {
+                        r = -c_errno();
+                        goto error;
+                }
         }
 
         r = bind(s, (struct sockaddr *)&address, sizeof(address));