colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

keyfile: fix memleak in read_hash_of_string()

Browse Source 
Fixes: 10661abe17
This commit is contained in:
Thomas Haller
2017-05-04 14:42:00 +02:00
parent a4cbfe6f0a
commit cb33e3f3c2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libnm-core/nm-keyfile-reader.c
View File

@@ -715,7 +715,8 @@ mac_address_parser_INFINIBAND (KeyfileReaderInfo *info, NMSetting *setting, cons
static void static void
read_hash_of_string (GKeyFile *file, NMSetting *setting, const char *key) read_hash_of_string (GKeyFile *file, NMSetting *setting, const char *key)
{ {
char **keys, **iter; gs_strfreev char **keys = NULL;
const char *const*iter;
char *value; char *value;
const char *setting_name = nm_setting_get_name (setting); const char *setting_name = nm_setting_get_name (setting);
@@ -723,7 +724,7 @@ read_hash_of_string (GKeyFile *file, NMSetting *setting, const char *key)
if (!keys || !*keys) if (!keys || !*keys)
return; return;
for (iter = keys; *iter; iter++) { for (iter = (const char *const*) keys; *iter; iter++) {
value = nm_keyfile_plugin_kf_get_string (file, setting_name, *iter, NULL); value = nm_keyfile_plugin_kf_get_string (file, setting_name, *iter, NULL);
if (!value) if (!value)
continue; continue;
@@ -739,7 +740,6 @@ read_hash_of_string (GKeyFile *file, NMSetting *setting, const char *key)
} }
g_free (value); g_free (value);
} }
g_strfreev (keys);
} }
static gsize static gsize