From cfa89feb5ec7fde99ecbb61e8650deefdf4bbc57 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 27 Sep 2018 16:51:56 +0200 Subject: [PATCH] libnm: use nm_free_secret() in nm-setting-macsec.c --- libnm-core/nm-setting-macsec.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libnm-core/nm-setting-macsec.c b/libnm-core/nm-setting-macsec.c index 2c7cff23b..2f67a6c2b 100644 --- a/libnm-core/nm-setting-macsec.c +++ b/libnm-core/nm-setting-macsec.c @@ -25,6 +25,8 @@ #include #include +#include "nm-utils/nm-secret-utils.h" + #include "nm-utils.h" #include "nm-core-types-internal.h" #include "nm-setting-connection.h" @@ -389,7 +391,7 @@ set_property (GObject *object, guint prop_id, priv->encrypt = g_value_get_boolean (value); break; case PROP_MKA_CAK: - g_free (priv->mka_cak); + nm_free_secret (priv->mka_cak); priv->mka_cak = g_value_dup_string (value); break; case PROP_MKA_CAK_FLAGS: @@ -462,10 +464,7 @@ finalize (GObject *object) NMSettingMacsecPrivate *priv = NM_SETTING_MACSEC_GET_PRIVATE (setting); g_free (priv->parent); - if (priv->mka_cak) { - memset (priv->mka_cak, 0, strlen (priv->mka_cak)); - g_free (priv->mka_cak); - } + nm_free_secret (priv->mka_cak); g_free (priv->mka_ckn); G_OBJECT_CLASS (nm_setting_macsec_parent_class)->finalize (object);