colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libnm: store NMConnectionPrivate via g_object_set_qdata()

Browse Source 
g_object_get_data() and g_object_get_qdata() end up to be identical,
except that g_object_get_data() also requires to intern the string
on every lookup (which involves a hash lookup and locking).
This commit is contained in:
Thomas Haller
2016-04-22 19:14:07 +02:00
parent 8bc895d5aa
commit d350d72a2e
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libnm-core/nm-connection.c
View File

@@ -2253,12 +2253,18 @@ nm_connection_private_free (NMConnectionPrivate *priv)
static NMConnectionPrivate * static NMConnectionPrivate *
nm_connection_get_private (NMConnection *connection) nm_connection_get_private (NMConnection *connection)
{ {
static GQuark key = 0;
NMConnectionPrivate *priv; NMConnectionPrivate *priv;
priv = g_object_get_data (G_OBJECT (connection), "NMConnectionPrivate"); nm_assert (NM_IS_CONNECTION (connection));
if (G_UNLIKELY (key == 0))
key = g_quark_from_static_string ("NMConnectionPrivate");
priv = g_object_get_qdata ((GObject *) connection, key);
if (!priv) { if (!priv) {
priv = g_slice_new0 (NMConnectionPrivate); priv = g_slice_new0 (NMConnectionPrivate);
g_object_set_data_full (G_OBJECT (connection), "NMConnectionPrivate", g_object_set_qdata_full ((GObject *) connection, key,
priv, (GDestroyNotify) nm_connection_private_free); priv, (GDestroyNotify) nm_connection_private_free);
priv->self = connection; priv->self = connection;