colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cli: disable setting 'rate' and 'tx-power' properties in editor

Browse Source 
The properties are not implemented in NM core, nor in ifcfg-rh plugin. Thus
they are not preserved over re-reading from ifcfg-* file. Moreover they are
highly dependent on drivers.
When we allowed editing them, the connection changed after re-reading and
was marked as dirty (and users were puzzled).
This commit is contained in:
Jiří Klimeš
2013-08-29 13:43:00 +02:00
parent d3abb8c79a
commit d646cf909f
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cli/src/settings.c
View File

@@ -4452,15 +4452,19 @@ nmc_properties_init (void)
NULL, NULL,
NULL, NULL,
NULL); NULL);
/*
* Do not allow setting 'rate' and 'tx-power'. They are not implemented in
* NM core, nor in ifcfg-rh plugin (thus not preserved over re-reading).
*/
nmc_add_prop_funcs (GLUE (WIRELESS, RATE), nmc_add_prop_funcs (GLUE (WIRELESS, RATE),
nmc_property_wireless_get_rate, nmc_property_wireless_get_rate,
nmc_property_set_uint, NULL, /* editing rate disabled */
NULL, NULL,
NULL, NULL,
NULL); NULL);
nmc_add_prop_funcs (GLUE (WIRELESS, TX_POWER), nmc_add_prop_funcs (GLUE (WIRELESS, TX_POWER),
nmc_property_wireless_get_tx_power, nmc_property_wireless_get_tx_power,
nmc_property_set_uint, NULL, /* editing tx-power disabled */
NULL, NULL,
NULL, NULL,
NULL); NULL);