From d73594682f7b9eef526bf19a3dba58f98686bcdd Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 25 Jan 2022 14:19:00 +0100 Subject: [PATCH] platform: no need to initialize nla sockaddr parameter to nl_recv() We always call nl_recv() in a loop. If it would be necessary to clear the variable, then it would need to happen inside the loop. But it's not necessary. --- src/libnm-platform/nm-linux-platform.c | 2 +- src/libnm-platform/nm-netlink.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libnm-platform/nm-linux-platform.c b/src/libnm-platform/nm-linux-platform.c index 44e662670..83f2207d3 100644 --- a/src/libnm-platform/nm-linux-platform.c +++ b/src/libnm-platform/nm-linux-platform.c @@ -9040,7 +9040,7 @@ event_handler_recvmsgs(NMPlatform *platform, gboolean handle_events) gboolean interrupted = FALSE; struct nlmsghdr *hdr; WaitForNlResponseResult seq_result; - struct sockaddr_nl nla = {0}; + struct sockaddr_nl nla; struct ucred creds; gboolean creds_has; unsigned char *buf; diff --git a/src/libnm-platform/nm-netlink.c b/src/libnm-platform/nm-netlink.c index 98f75f604..697ae5919 100644 --- a/src/libnm-platform/nm-netlink.c +++ b/src/libnm-platform/nm-netlink.c @@ -1171,7 +1171,7 @@ nl_recvmsgs(struct nl_sock *sk, const struct nl_cb *cb) int n, nmerr = 0, multipart = 0, interrupted = 0, nrecv = 0; gs_free unsigned char *buf = NULL; struct nlmsghdr *hdr; - struct sockaddr_nl nla = {0}; + struct sockaddr_nl nla; struct ucred creds; gboolean creds_has;