colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

supplicant: fix crash passing invalid parameter to AddBlob when adding network

Browse Source 
The DBUS method 'AddBlob' expects a data argument of type 'ay'.
Instead we passed the hash table 'blobs'.

This must be broken for a long time and surprisingly stayed unnoticed.

https://mail.gnome.org/archives/networkmanager-list/2014-July/msg00001.html

Fixes: fb6cde508c
Signed-off-by: Thomas Haller <thaller@redhat.com>
This commit is contained in:
Thomas Haller
2014-07-02 10:58:49 +02:00
parent 0ce2d2618c
commit e343c45ebb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/supplicant-manager/nm-supplicant-interface.c
View File

@@ -1081,7 +1081,7 @@ add_network_cb (DBusGProxy *proxy, DBusGProxyCall *call_id, gpointer user_data)
self, self,
NULL, NULL,
DBUS_TYPE_STRING, name, DBUS_TYPE_STRING, name,
DBUS_TYPE_G_UCHAR_ARRAY, blobs, DBUS_TYPE_G_UCHAR_ARRAY, data,
G_TYPE_INVALID); G_TYPE_INVALID);
nm_call_store_add (priv->assoc_pcalls, priv->iface_proxy, call); nm_call_store_add (priv->assoc_pcalls, priv->iface_proxy, call);
} }