From ed21a820a7566d35d5f35d25537dd84246f00aa5 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Sat, 8 Oct 2016 13:36:05 +0200 Subject: [PATCH] libnm/tests: connection might not be gone at the time manager signals removal The assumption is not too useful to the library user anyway -- it could easily be that there's some other link to the object in the object tree. More importantly, when the objects are managed by the object manager, we don't destroy the object until we see it actually removed on the D-Bus. That makes more sense anyway. --- libnm/tests/test-remote-settings-client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libnm/tests/test-remote-settings-client.c b/libnm/tests/test-remote-settings-client.c index fda943c80..f6c37e919 100644 --- a/libnm/tests/test-remote-settings-client.c +++ b/libnm/tests/test-remote-settings-client.c @@ -336,9 +336,10 @@ test_remove_connection (void) do { now = time (NULL); g_main_context_iteration (NULL, FALSE); - } while ((done == FALSE) && (now - start < 5)); + if (done && !remote) + break; + } while (now - start < 5); g_assert (done == TRUE); - g_assert (!remote); /* Ensure NMClient no longer has the connection */