colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clients: fix keyfile string memory leak

Browse Source 
The return value of g_key_file_get_string() was leaked.

Fixes: 5a0d67f739
(cherry picked from commit 082ae508a0)
This commit is contained in:
Beniamino Galvani
2019-03-04 14:29:30 +01:00
parent 72f40fc421
commit efce1e34f2
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
clients/common/nm-secret-agent-simple.c
View File

@@ -600,12 +600,15 @@ _auth_dialog_exited (GPid pid, int status, gpointer user_data)
goto out; goto out;
for (i = 1; groups[i]; i++) { for (i = 1; groups[i]; i++) {
gs_free char *pretty_name = NULL;
if (!g_key_file_get_boolean (keyfile, groups[i], "IsSecret", NULL)) if (!g_key_file_get_boolean (keyfile, groups[i], "IsSecret", NULL))
continue; continue;
if (!g_key_file_get_boolean (keyfile, groups[i], "ShouldAsk", NULL)) if (!g_key_file_get_boolean (keyfile, groups[i], "ShouldAsk", NULL))
continue; continue;
g_ptr_array_add (secrets, _secret_real_new_vpn_secret (g_key_file_get_string (keyfile, groups[i], "Label", NULL), pretty_name = g_key_file_get_string (keyfile, groups[i], "Label", NULL);
g_ptr_array_add (secrets, _secret_real_new_vpn_secret (pretty_name,
NM_SETTING (s_vpn), NM_SETTING (s_vpn),
groups[i], groups[i],
nm_setting_vpn_get_service_type (s_vpn))); nm_setting_vpn_get_service_type (s_vpn)));