dnsmasq-manager: lazy create debug logging string
The logging macros evaluate their arguments only when necessary. This saves creating the message in case debug logging is disabled.
This commit is contained in:
@@ -335,7 +335,7 @@ nm_dnsmasq_manager_start (NMDnsMasqManager *manager,
|
|||||||
{
|
{
|
||||||
NMDnsMasqManagerPrivate *priv;
|
NMDnsMasqManagerPrivate *priv;
|
||||||
NMCmdLine *dm_cmd;
|
NMCmdLine *dm_cmd;
|
||||||
char *cmd_str;
|
gs_free char *cmd_str = NULL;
|
||||||
|
|
||||||
g_return_val_if_fail (NM_IS_DNSMASQ_MANAGER (manager), FALSE);
|
g_return_val_if_fail (NM_IS_DNSMASQ_MANAGER (manager), FALSE);
|
||||||
if (error)
|
if (error)
|
||||||
@@ -353,9 +353,8 @@ nm_dnsmasq_manager_start (NMDnsMasqManager *manager,
|
|||||||
|
|
||||||
nm_log_info (LOGD_SHARING, "Starting dnsmasq...");
|
nm_log_info (LOGD_SHARING, "Starting dnsmasq...");
|
||||||
|
|
||||||
cmd_str = nm_cmd_line_to_str (dm_cmd);
|
nm_log_dbg (LOGD_SHARING, "Command line: %s",
|
||||||
nm_log_dbg (LOGD_SHARING, "Command line: %s", cmd_str);
|
(cmd_str = nm_cmd_line_to_str (dm_cmd)));
|
||||||
g_free (cmd_str);
|
|
||||||
|
|
||||||
priv->pid = 0;
|
priv->pid = 0;
|
||||||
if (!g_spawn_async (NULL, (char **) dm_cmd->array->pdata, NULL,
|
if (!g_spawn_async (NULL, (char **) dm_cmd->array->pdata, NULL,
|
||||||
|
Reference in New Issue
Block a user