colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dnsmasq-manager: lazy create debug logging string

Browse Source 
The logging macros evaluate their arguments only when necessary.
This saves creating the message in case debug logging is disabled.
This commit is contained in:
Thomas Haller
2016-01-30 19:26:43 +01:00
parent d442dcd174
commit f04e554f08
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/dnsmasq-manager/nm-dnsmasq-manager.c
View File

@@ -335,7 +335,7 @@ nm_dnsmasq_manager_start (NMDnsMasqManager *manager,
{ {
NMDnsMasqManagerPrivate *priv; NMDnsMasqManagerPrivate *priv;
NMCmdLine *dm_cmd; NMCmdLine *dm_cmd;
char *cmd_str; gs_free char *cmd_str = NULL;
g_return_val_if_fail (NM_IS_DNSMASQ_MANAGER (manager), FALSE); g_return_val_if_fail (NM_IS_DNSMASQ_MANAGER (manager), FALSE);
if (error) if (error)
@@ -353,9 +353,8 @@ nm_dnsmasq_manager_start (NMDnsMasqManager *manager,
nm_log_info (LOGD_SHARING, "Starting dnsmasq..."); nm_log_info (LOGD_SHARING, "Starting dnsmasq...");
cmd_str = nm_cmd_line_to_str (dm_cmd); nm_log_dbg (LOGD_SHARING, "Command line: %s",
nm_log_dbg (LOGD_SHARING, "Command line: %s", cmd_str); (cmd_str = nm_cmd_line_to_str (dm_cmd)));
g_free (cmd_str);
priv->pid = 0; priv->pid = 0;
if (!g_spawn_async (NULL, (char **) dm_cmd->array->pdata, NULL, if (!g_spawn_async (NULL, (char **) dm_cmd->array->pdata, NULL,