colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clients: fix i/o stream memory leaks

Browse Source 
Fixes: 5a0d67f739
(cherry picked from commit 91a644d4a5)
This commit is contained in:
Beniamino Galvani
2019-03-04 17:56:32 +01:00
parent efce1e34f2
commit f1628ea6f1
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
clients/common/nm-secret-agent-simple.c
View File

@@ -537,6 +537,8 @@ typedef struct {
GCancellable *cancellable; GCancellable *cancellable;
gulong cancellable_id; gulong cancellable_id;
guint child_watch_id; guint child_watch_id;
GInputStream *input_stream;
GOutputStream *output_stream;
char read_buf[5]; char read_buf[5];
} AuthDialogData; } AuthDialogData;
@@ -549,6 +551,8 @@ _auth_dialog_data_free (AuthDialogData *data)
g_ptr_array_unref (data->secrets); g_ptr_array_unref (data->secrets);
g_spawn_close_pid (data->auth_dialog_pid); g_spawn_close_pid (data->auth_dialog_pid);
g_string_free (data->auth_dialog_response, TRUE); g_string_free (data->auth_dialog_response, TRUE);
g_object_unref (data->input_stream);
g_object_unref (data->output_stream);
g_slice_free (AuthDialogData, data); g_slice_free (AuthDialogData, data);
} }
@@ -803,6 +807,8 @@ try_spawn_vpn_auth_helper (RequestData *request,
.auth_dialog_pid = auth_dialog_pid, .auth_dialog_pid = auth_dialog_pid,
.request = request, .request = request,
.secrets = g_ptr_array_ref (secrets), .secrets = g_ptr_array_ref (secrets),
.input_stream = auth_dialog_out,
.output_stream = auth_dialog_in,
}; };
g_output_stream_write_async (auth_dialog_in, g_output_stream_write_async (auth_dialog_in,