colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

systemd: remove code comment from "NetworkManager-wait-online.service.in"

Browse Source 
> If there is no network [1] to connect to (if network interface is down [2])
> NetworkManager will make "nm-online -s" stop [3] without waiting.

[1] we usually talk about connection profiles or devices/interfaces
[2] it would be better to say, if no suitable profile is ready to
  autoconnect.
[3] `nm-online -s` waits until NetworkManager declares "startup
complete" reached.

I find the wording of the comment not very clear or useful.
Possibly I don't understand it properly, but that is a problem
for a comment that is supposed to help.

Remove it.
This commit is contained in:
Thomas Haller
2020-11-16 16:42:42 +01:00
parent acef72c0cb
commit f59f1a25b4
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
data/NetworkManager-wait-online.service.in
View File

@@ -26,8 +26,6 @@ RemainAfterExit=yes
# gets delayed too long, then the solution is usually not to decrease # gets delayed too long, then the solution is usually not to decrease
# the timeout, but to fix your setup so that the connected state # the timeout, but to fix your setup so that the connected state
# gets reached earlier. # gets reached earlier.
# If there is no network to connect to (if network interface is down),
# NetworkManager will make "nm-online -s" stop without waiting.
Environment=NM_ONLINE_TIMEOUT=60 Environment=NM_ONLINE_TIMEOUT=60
[Install] [Install]