Commit Graph

21 Commits

Author SHA1 Message Date
Thomas Haller
aaf0ef42dd nm-online: refactor calculation of wait timeout for better accuracy
Also, in verbose mode, synchronize the printing of the progress
bar and the counting seconds so that the output appears smooth.

This schedules the timeouts so that there are roughly
(PROGRESS_STEPS + n_secs) wakeups.

https://bugzilla.gnome.org/show_bug.cgi?id=728163

Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-06-20 08:15:37 +02:00
Jiří Klimeš
98ae6e06d2 all: g_type_init() has been deprecated in GLib 2.35.0
g_type_init() deprecation:
https://bugzilla.gnome.org/show_bug.cgi?id=686161
2014-05-27 16:58:21 +02:00
Thomas Haller
0a85bff70a nm-online: fix considering the --quiet option
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-03-31 08:37:10 +02:00
Jiří Klimeš
ea962ce411 trivial: correct nm-online's '--exit' option description 2014-03-31 08:37:10 +02:00
Jiří Klimeš
20fb078dd6 nm-online: fix nm-online to report online status correctly (rh #1054364)
This fixes a behaviour change made by 44ac1020da.
That commit make nm-online to wait for NM finishing startup instead of waiting
for a real connection. So for NetworkManager fully initialized, but
disconnected nm-online would return 0.

$ nmcli -f RUNNING,STATE,STARTUP,CONNECTIVITY gen status
RUNNING  STATE         STARTUP  CONNECTIVITY
running  disconnected  started  none

Revert back to the original behaviour of waiting for a connection. And
introduce a new option '--wait-for-startup' waiting for NetworkManager
finishing its startup, which is useful in some cases, like
NetworkManager-wait-online.service.

https://bugzilla.redhat.com/show_bug.cgi?id=1054364
2014-03-31 08:37:10 +02:00
Jiří Klimeš
15ade8a0ca nm-online: check return value of nm_client_new() 2013-10-14 08:48:06 +02:00
Dan Winship
44ac1020da nm-online: wait for all startup-time connections, not just one
Rewrite nm-online to use libnm-glib, and change it so that it waits
until NM has finished all of its startup-time connection activation
attempts, rather than only waiting until at least one has succeeded.

In particular, this means that on multi-homed servers, the
NetworkManager-wait-online systemd service (and by extension,
network.service) will now block until *all* of the server's IP
addresses are up, which is needed for some old daemons that assume
that no network interfaces will be added after they start.
2013-08-16 17:27:34 -04:00
Dan Winship
fe8275aa7e nm-online: fix indentation, etc 2013-07-23 09:07:39 -04:00
Jiří Klimeš
fc9f7e06b9 nm-online: describe '--timeout' option more exactly (rh #969363) 2013-07-11 15:21:22 +02:00
Dan Winship
6878d20ac4 all: Don't use ctype.h macros
The ctype macros (eg, isalnum(), tolower()) are locale-dependent. Use
glib's ASCII-only versions instead.

Also, replace isascii() with g_ascii_isprint(), since isascii()
accepts control characters, which isn't what the code wanted in any of
the places where it was using it.
2012-09-26 12:14:37 -04:00
Jiří Klimeš
21f8468708 nm-online: internationalize nm-online tool 2012-07-09 16:21:11 +02:00
Dan Williams
ec115ed442 api: add additional NM daemon states
DISCONNECTING: the only active network connection is now being disconnected
LOCAL, SITE, GLOBAL: one-stop items for level of connectivity, which
we'll use to show when we think we're actually connected to the internet
or behind a captive portal or something
2011-02-14 17:55:27 -06:00
Dan Williams
d0ec39e66d nm-online: print warnings not critical errors (rh #593677)
Otherwise we'll segfault if critical errors are set to abort.
2010-05-20 00:22:56 -07:00
Michael Biebl
1c3c6c2a66 Remove DBUS_API_SUBJECT_TO_CHANGE
We require dbus 1.1 anyway
2009-05-02 18:00:22 -04:00
Jan Kantert
4ca66db721 Use g_timeout_add_seconds() to reduce wakeups
(and refine the older glib compat mechanism, by Dan)
2008-12-31 18:57:36 -05:00
Dan Williams
3f907cb9e3 License header and FSF address update 2008-12-20 09:46:41 -05:00
Dan Williams
95c44ecc1f 2008-04-15 Dan Williams <dcbw@redhat.com>
Enhance nm-online based on a patch from Bill Nottingham.

	* test/nm-online.c
		- Add a '-q' option
		- Add help messages and option summary
		- Add long-format options
		- Add a '-x' option to exit if NM isn't running or isn't connecting



git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@3561 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2008-04-15 19:47:23 +00:00
Robert Love
0e5527128e Header fix.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1724 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2006-05-09 15:22:25 +00:00
Robert Love
5bdf83737b 2006-05-02 Robert Love <rml@novell.com>
Patch by Timo Hoenig;
	* tests/nm-online.c: Print pretty status indicator as timeout winds
	  down.  Also fix possible race between DBUS startup and failure
	  return.


git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1714 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2006-05-02 14:47:59 +00:00
Robert Love
fc4797caaf Default to 30, not 60, seconds.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1709 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2006-04-26 19:43:53 +00:00
Robert Love
1558cd6be3 readd?
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1707 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2006-04-26 19:34:03 +00:00