Commit Graph

7740 Commits

Author SHA1 Message Date
Pavel Šimerda
998f4ccc88 build: add code coverage support
Use the following in Makefile.am to enable code coverage for individual modules:

@GNOME_CODE_COVERAGE_RULES@
my_program_LIBS = … $(CODE_COVERAGE_LDFLAGS) …
my_program_CFLAGS = … $(CODE_COVERAGE_CFLAGS) …
2013-01-08 13:30:56 +01:00
Dan Winship
1d89bc0004 systemd: set KillMode=process
By default, when shutting NM down, systemd will kill everything in its
cgroup. But this can cause problems (eg, NM thinking that dhclient
crashed and then taking down an interface that it would otherwise have
left up). Fix this by setting KillMode=process, which tells systemd to
only kill NM itself, and let NM kill its children.

https://bugzilla.redhat.com/show_bug.cgi?id=876218
2013-01-04 11:53:03 -05:00
Alban Browaeys
e78c3e83d2 build: negate the grep result. Not the echo result.
https://bugzilla.gnome.org/show_bug.cgi?id=690991
2013-01-02 12:50:32 -05:00
Alban Browaeys
338f1e4e6a build: Fix with_session_tracking check vs consolkit.
Fix with_session_tracking check vs consolkit,
missing dollar before identifier.

https://bugzilla.gnome.org/show_bug.cgi?id=690991
2013-01-02 12:50:32 -05:00
Pavel Šimerda
a787e5c585 build: cleanups 2012-12-28 19:21:25 +01:00
Guido Günther
1208f6e512 build: various session tracking fixes 2012-12-28 19:00:07 +01:00
Aleksander Morgado
6c16796119 modem-manager: avoid assertion when exposed modem has no 3GPP/3GPP2 capabilities
If, for any reason, MM exposes a modem object without 3GPP or 3GPP2
capabilities, just return an error instead of assert()-ing.
2012-12-19 10:29:13 -06:00
Dan Williams
94d6074e26 core: fix crash on device deactivation after 'pending' branch merge
Since the manager now tracks active connections, it needs to hold
a reference to the active connection objects too.  The active
connection teardown code was changed to release that reference
(_active_connection_cleanup()) but the creation code was never
changed to remove the bits that pass ownership over the initial
reference to the NMDevice.  Fix that.
2012-12-18 21:06:02 -06:00
Pavel Šimerda
a596db45f0 build: add --enable-tests=root to enable tests that require uid=0 2012-12-18 14:15:13 +01:00
Jiří Klimeš
954ce65e99 ifcfg-rh: treat missing IPv6 setting as IPv6 "auto" method (rh #830434) 2012-12-18 10:40:35 +01:00
Dan Williams
c0d15e8eb2 trivial: remove unused argument 2012-12-17 17:01:11 -06:00
Dan Williams
9065f247c3 vpn: reduce memory usage a bit
No need to copy the list when (a) we never care if it gets modified
in-place (since the loops break when the connection is found) and
(b) we never modify it in place anyway.  Reduces the possibility of
leaking the list due to programming errors too.
2012-12-17 17:01:11 -06:00
Dan Williams
1fcb577e19 vpn: make nm_vpn_manager_deactivate_connection() take an object, not a path
Pointless to look up the object by its path when we already have the object.
2012-12-17 17:01:11 -06:00
Dan Williams
1b968f4021 core: simplify looking up NMActiveConnection objects by object path 2012-12-17 17:01:10 -06:00
Dan Williams
43813cc563 vpn: remove unused connection activated/deactivated signals
Replaced by watching the connections' states directly.
2012-12-17 17:01:10 -06:00
Dan Williams
f8f1a131f5 policy: monitor connection activation/deactivation via the manager
Instead of through the VPN manager.
2012-12-17 17:01:10 -06:00
Dan Williams
92ea35469d core: add manager active connection added/removed signals
Will replace the VPN manager's activated/deactivated signals; listeners
can attach to the active connection's 'state' property and listen
for the changes to ACTIVATED and DEACTIVATED.  Works for all connections,
not just VPN ones.
2012-12-17 17:01:10 -06:00
Dan Williams
6ddc25dcab core: handle some connection timestamp updating in NMActiveConnection
Handle it in the base active connection class instead of in separate
places for the device and the VPN cases.
2012-12-17 17:01:10 -06:00
Dan Williams
3a10f695b3 vpn: kill nm_vpn_manager_get_vpn_connection_for_active()
No longer required now that the manager tracks active connections.
2012-12-17 17:01:10 -06:00
Dan Williams
a64127a7c2 vpn: kill nm_vpn_manager_get_active_connections()
No longer needed now that the manager tracks active connections.
2012-12-17 17:01:10 -06:00
Dan Williams
59420add04 core: track active connections directly in the manager
Instead of using devices as a proxy for active connections, and
then also asking the VPN manager for the active connections it's
tracking, just track *all* active connections in the manager.
2012-12-17 17:01:10 -06:00
Dan Williams
7258dd270f core: add the NM_ACTIVE_CONNECTION_STATE_DEACTIVATED state
We'll use this to know when to clean up and dispose of the
active connection in the manager.
2012-12-17 17:01:10 -06:00
Dan Williams
abad22f87e vpn: kill nm_vpn_connection_get_name()
Replaced by nm_connection_get_id().
2012-12-17 17:01:10 -06:00
Dan Williams
84603c2380 core: move most activation request logic to the active connection class
We'll want to use NMActiveConnection more in the manager and also fold
the PendingActivation functionality into it.  All this functionality
applies to the VPN connections too, so it makes sense to have it all
in the base class instead of both NMActRequest and NMVPNConnection.
2012-12-17 17:01:10 -06:00
Dan Williams
7a3c53e8ff core: add header for NM object types
Helps prevent #include loops when two objects need each other's
headers, like NMActiveConnection and NMDevice.
2012-12-17 17:01:10 -06:00
Jiří Klimeš
cfb391952d policy: fix logging address for reverse-lookup in hostname4_thread_new() 2012-12-17 19:48:40 +01:00
Colin Walters
1b84012762 libnm-glib: clarify documentation of nm_client_get_devices() 2012-12-13 17:12:11 -06:00
Jiří Klimeš
383a397a92 vpn: fix ifindex value check
Valid interface indexes are greater than zero.
2012-12-13 19:06:23 +01:00
Pavel Šimerda
83c6ebcee7 ifnet: avoid -Wformat-security errors 2012-12-11 23:06:10 +01:00
Jiří Klimeš
8a9759af4b examples: fix nm-state.py example 2012-12-07 15:13:22 +01:00
Dan Williams
a455d42de2 dnsmasq: only pass confdir if it exists (rh #873621)
dnsmasq exits if the --conf-dir does not exist.  Which isn't
very useful.

Inspired by Federico Simoncelli <fsimonce@redhat.com>:
https://mail.gnome.org/archives/networkmanager-list/2012-June/msg00011.html
2012-12-06 15:18:28 -06:00
Dan Williams
fcdbf17f35 dnsmasq: trivial cleanup
Use an index variable so we dont' have to keep track of indexes
manually.
2012-12-06 15:18:24 -06:00
Dan Williams
f1f0ada0c6 wifi: always enable proactive key caching for WPA Enterprise (rh #834444)
Proactive Key Caching (also called Opportunistic Key Caching) allows
fast roaming between access points in the same SSID on large enterprise
or university networks.  Previously it was only enabled for EAP-GTC
but there's no reason to restrict it only to that EAP type, as all
large wifi deployments can benefit from it.
2012-12-06 14:58:46 -06:00
Jiří Klimeš
e7add58aad main: ensure NMSTATEDIR exists (bgo #689744)
For OSTree/gnome-ostree, the model chosen for /var is that services
are responsible for creating any data they need in /var at runtime.

Call g_mkdir_with_parents() to ensure NMSTATEDIR exists.

https://bugzilla.gnome.org/show_bug.cgi?id=689744

Based on Colin Walters' patch.
2012-12-06 16:51:17 +01:00
Krishna Babu K
76e8f60212 po: updated Telugu (te) translation (bgo #689213) 2012-12-06 14:42:08 +01:00
Manoj Kumar Giri
9bf97aa584 po: updated Oriya (Odia) (or) translation (bgo #689150) 2012-12-06 14:06:24 +01:00
Ani Peter
62fe4f65b7 po: updated Malayalam (ml) translation (bgo #689133) 2012-12-06 13:56:22 +01:00
Runa Bhattacharjee
95b33c811b po: updated Bengali (bn_IN) translation (bgo #689131) 2012-12-06 13:46:51 +01:00
Rajesh Ranjan
f5ea8c234a po: updated Hindi (hi) translation (bgo #688925) 2012-12-06 13:41:31 +01:00
Sandeep Shedmake
bd6bb94e7f po: updated Marathi (mr) translation (bgo #688854) 2012-12-06 13:34:18 +01:00
Pavel Šimerda
aa52ca327a build: enable silent rules 2012-12-05 23:22:21 +01:00
Pavel Šimerda
13b8301fda build: clean up --with-session-tracking 2012-12-05 23:22:21 +01:00
Mathieu Trudel-Lapierre
f41f41506c dhcp: ensure hostname is sent to the DHCP server for default wired connections
For the default wired connection (or any connection that doesn't have an IPv4
setting, which means "auto"), the hostname should always be sent to the DHCP
server to register in DNS.
2012-12-04 12:21:24 -06:00
Dan Williams
e651169a3d libnm-util: fix format string warning 2012-12-04 12:06:20 -06:00
Dan Williams
8b7287ab66 core: fix agent secret cancelation
Two issues here: first, the daemon code was using the wrong D-Bus type
(strings instead of object-path) to send the connection path to the
secret agent, which resulted in a method-not-found error and nothing
happening in the agent.

Second, the agent-side method call verification code would fail the
request anyway, becuase verify_request() determined success based
on the reconstructed connection, which isn't given when canceling
secrets requests.
2012-12-04 11:31:12 -06:00
Jiří Klimeš
cf74d74fcc sleep-monitor: make the systemd's sleep also work for GLib < 2.30
GDBus is only available from glib 2.26 and GUnixFDList from glib 2.30
2012-12-04 11:30:20 -06:00
Jiří Klimeš
3c9ba7d895 core: set GError on failures in nm-dnsmasq-manager.c:create_dm_cmd_line() 2012-12-04 16:10:46 +01:00
Jiří Klimeš
1df1e85093 core: don't crash in start_sharing() on failures (if error is NULL) (rh #883142) 2012-12-04 15:55:30 +01:00
Evan Nemerson
208c53e5d6 build: quote $@ in autogen.sh
https://bugzilla.gnome.org/show_bug.cgi?id=689512
2012-12-03 16:04:35 -05:00
Dan Winship
829234fd8d libnm-glib: more NMDevice::state-changed fixes
Ensure that NMDevice::state-changed signals don't get emitted out of
order, and ensure that nm_device_get_state() from a ::state-changed
handler always returns new_state.
2012-12-03 15:19:53 -05:00