colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
11,890 Commits 4 Branches 0 Tags
e65639bde9247ce597ddd77d4fda643b11e66b9c
Commit Graph

11890 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Thomas Haller
bf68917ca3 libnm/tests: add valgrind suppressions 2015-02-09 12:10:13 +01:00
Thomas Haller
76745817c3 libnm/tests: fix memleaks in test code for valgrind 2015-02-09 11:51:08 +01:00
Thomas Haller
c50f30e79c tests: enable valgrind tests for tests 2015-02-09 11:51:07 +01:00
Thomas Haller
6853d07f05 platform/tests: reenable valgrind tests 
valgrind tests for platform were wrongly disabled.

Fixes: e3784fa618
 2015-02-09 11:51:07 +01:00
Thomas Haller
d5f8312996 tests: add valgrind suppression for callouts tests 2015-02-09 11:51:07 +01:00
Thomas Haller
171a9eabc6 tests: add valgrind suppression for test-general-with-expect 
==8781== Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s)
    ==8781==    at 0x5E547DD: __libc_sigaction (sigaction.c:64)
    ==8781==    by 0x8149025: unref_unix_signal_handler_unlocked (gmain.c:4981)
    ==8781==    by 0x81490BF: g_child_watch_finalize (gmain.c:5025)
    ==8781==    by 0x8149535: g_source_unref_internal (gmain.c:1997)
    ==8781==    by 0x814C377: g_main_context_dispatch (gmain.c:3094)
    ==8781==    by 0x814C627: g_main_context_iterate.isra.24 (gmain.c:3713)
    ==8781==    by 0x814CA39: g_main_loop_run (gmain.c:3907)
    ==8781==    by 0x11AC8B: test_nm_utils_kill_child_async_do (test-general-with-expect.c:90)
    ==8781==    by 0x119769: test_nm_utils_kill_child (test-general-with-expect.c:292)
    ==8781==    by 0x81705E0: g_test_run_suite_internal (gtestutils.c:2067)
    ==8781==    by 0x81707A5: g_test_run_suite_internal (gtestutils.c:2138)
    ==8781==    by 0x8170B1A: g_test_run_suite (gtestutils.c:2189)
    ==8781==  Address 0xffeffed28 is on thread 1's stack
    ==8781==
    {
       <insert_a_suppression_name_here>
       Memcheck:Param
       rt_sigaction(act->sa_flags)
       fun:__libc_sigaction
       fun:unref_unix_signal_handler_unlocked
       fun:g_child_watch_finalize
       fun:g_source_unref_internal
       fun:g_main_context_dispatch
       fun:g_main_context_iterate.isra.24
       fun:g_main_loop_run
       fun:test_nm_utils_kill_child_async_do
       fun:test_nm_utils_kill_child
       fun:g_test_run_suite_internal
       fun:g_test_run_suite_internal
       fun:g_test_run_suite
    }
 2015-02-09 11:51:07 +01:00
Thomas Haller
624aa51614 supplicant/tests: fix memleaks in test code for valgrind 2015-02-09 11:51:07 +01:00
Thomas Haller
d74a3d0a02 dhcp/tests: fix memleaks in test code for valgrind 2015-02-09 11:51:07 +01:00
Thomas Haller
63f5a22ad7 config/tests: fix memleak in test code for valgrind 2015-02-09 11:51:07 +01:00
Thomas Haller
a82d94a64e device: refactor dispose/cleanup of NMDevice to free members in finalize 
NMTestDevice does not invoke dispose(), hence it leaks memory which causes
false warnings in testing.
Some minor refactring to let dispose() clear the fields, but free it
later in finalize(). This avoids memleaks in the NMTestDevice stub.
 2015-02-09 11:51:07 +01:00
Thomas Haller
ae73320b8c libnm/tests: fix memleaks in tests for valgrind 2015-02-09 11:51:07 +01:00
Thomas Haller
0750d934bf ifcfg-rh/tests: fix memleaks in test code for valgrind 2015-02-09 11:51:07 +01:00
Thomas Haller
fbe8c0ed87 ibft/tests: fix memleaks in test code for valgrind 2015-02-09 11:51:07 +01:00
Thomas Haller
9a2f2ed7fd keyfile/tests: fix memleaks in test code for valgrind 2015-02-09 11:51:07 +01:00
Thomas Haller
1ba16f44cf callouts/tests: fix memleak in test code for valgrind 2015-02-09 11:51:06 +01:00
Thomas Haller
1680bf3ad1 core/tests: fix memleak in tests to avoid valgrind warnings 2015-02-09 11:51:06 +01:00
Thomas Haller
1935fca09a dhcp: fix memleak in process_dhclient_rfc3442_route() 2015-02-09 11:51:06 +01:00
Thomas Haller
a9bfe9f4bb ifcfg-rh: fix memleak in write_ip4_aliases() and assert against overflow 2015-02-09 11:51:06 +01:00
Thomas Haller
53796f0beb ifcfg-rh: fix memleaks in reader 2015-02-09 11:51:06 +01:00
Thomas Haller
fcfd8f487a ifcfg-rh: fix memleak due to make_wpa_setting() returning both wsec and error 
==10501== 353 (32 direct, 321 indirect) bytes in 1 blocks are definitely lost in loss record 1,579 of 1,641
    ==10501==    at 0x7EE3728: g_type_create_instance (gtype.c:1847)
    ==10501==    by 0x7EC75B4: g_object_new_internal (gobject.c:1746)
    ==10501==    by 0x7EC945C: g_object_newv (gobject.c:1890)
    ==10501==    by 0x7EC9C23: g_object_new (gobject.c:1556)
    ==10501==    by 0x1CD87C: nm_setting_wireless_security_new (nm-setting-wireless-security.c:122)
    ==10501==    by 0x16F70B: make_wpa_setting (reader.c:3010)
    ==10501==    by 0x16F33F: make_wireless_security_setting (reader.c:3188)
    ==10501==    by 0x161F4C: wireless_connection_from_ifcfg (reader.c:3464)
    ==10501==    by 0x16109A: connection_from_file_full (reader.c:4763)
    ==10501==    by 0x1614EE: connection_from_file_test (reader.c:4862)
    ==10501==    by 0x13D1D6: test_read_wifi_wpa_psk_unquoted2 (test-ifcfg-rh.c:4316)
    ==10501==    by 0x1281FD: main (test-ifcfg-rh.c:12513)
    ==10501==
 2015-02-09 11:51:06 +01:00
Thomas Haller
98a0299265 ifcfg-rh: fix memleak in svSetValue() 2015-02-09 11:51:06 +01:00
Thomas Haller
494c5c395d ibft: fix memleak in read_ibft_blocks() 2015-02-09 11:51:06 +01:00
Thomas Haller
9d8f93384a keyfile: fix memleak in parity_parser() 2015-02-09 11:51:05 +01:00
Thomas Haller
b7cb109ad3 config: fix memleak in NMConfigData keyfile 2015-02-09 11:51:05 +01:00
Thomas Haller
b49fdae59e config: fix memleak in read_config() 2015-02-09 11:51:05 +01:00
Thomas Haller
027ab3efaa libnm-util: only unref and don't destroy hash in nm_connection_to_hash() 
The returned hash from nm_connection_to_hash() used to destroy the
nested hashes, instead of only unrefing them.
 2015-02-09 11:51:05 +01:00
Thomas Haller
1567a9f712 libnm: fix memleak in _nm_dbus_bind_properties() 2015-02-09 11:51:05 +01:00
Thomas Haller
137e496ef1 libnm: fix memleaks in nm_setting_802_1x 2015-02-09 11:51:05 +01:00
Thomas Haller
7a82d64e47 libnm: fix memleak in nm_setting_wired_get_s390_option() and refactor 
@keys was leaked. Also refactor the function to iterate the hash only
once.
 2015-02-09 11:51:05 +01:00
Thomas Haller
f1bfe459ee libnm: fix memleak in find_virtual_interface_name() 2015-02-09 11:51:05 +01:00
Thomas Haller
fffd93b5c4 libnm: fix memleak in nm_connection_replace_settings() 2015-02-09 11:51:05 +01:00
Thomas Haller
66be46309a libnm: fix memleak in nm_utils_ip_addresses_from_variant() 2015-02-09 11:51:05 +01:00
Thomas Haller
8cb6d70e5b libnm: fix memleak for config in NMSettingTeamPort 2015-02-09 11:51:05 +01:00
Thomas Haller
052198f4b9 libnm: fix memleak for app_fcoe_mode in NMSettingDcb 2015-02-09 11:51:04 +01:00
Thomas Haller
fdd09340ce cli: fix memleak in nmc_setting_get_valid_properties() 2015-02-09 11:51:04 +01:00
Jiří Klimeš
f124848b60 examples: add a Lua example showing basic NetworkManager information 2015-02-09 10:11:18 +01:00
Jiří Klimeš
3d991b8e32 examples: add a Lua example for getting Wi-Fi access points 2015-02-09 10:11:12 +01:00
Thomas Haller
9a2c0451a4 tests: fix valgrind script to handle exit value 77 (skip) 2015-02-06 12:58:42 +01:00
Thomas Haller
14040b1cea callouts/tests: fix parsing dhcp in get_dispatcher_file() 2015-02-06 12:58:22 +01:00
Dan Williams
f3b16fffbd wwan: recheck available connections when modem becomes unlocked (bgo #740966) 
NMDevice rechecks available connections when the device moves to the
DISCONNECTED state, but connections are not available if the modem is
PIN locked at that time.  Available connections were never re-checked
when the modem was then unlocked while in the DISCONNECTED state.
 2015-02-05 11:09:22 +01:00
Dan Williams
81affd4ff1 core: fix session-monitor build with --with-session-tracking=none 2015-02-05 11:09:22 +01:00
Lubomir Rintel
41c87eb363 wwan: fix wrong assert in deactivate_cleanup() 
When the modem device is abruptly disconnected,
nm_modem_device_state_changed() calls deactivate_cleanup() with a NULL
device argument and that's perfectly fine.

We should only check the instance type if we know the device is non-NULL.

(NetworkManager:9166): NetworkManager-wwan-CRITICAL **: deactivate_cleanup: assertion 'NM_IS_DEVICE ( failed
 2015-02-04 10:54:59 +01:00
Thomas Haller
f9e4af2d86 config,connectivity: merge branch 'th/rh1066697_reload_config' 
Refactor NMConfig to support reloading.

Implement reloading of NMConnectivity parameters

https://bugzilla.redhat.com/show_bug.cgi?id=1066697
 2015-02-03 15:49:11 +01:00
Thomas Haller
5b47462f32 config: use flags argument in config-changed signal instead of a hash table 2015-02-03 13:01:54 +01:00
Thomas Haller
cc46b182ed config: make NMConfig implement GInitable 2015-02-03 13:01:53 +01:00
Thomas Haller
13c7f6a56d config: move no-auto-default to NMConfigData 
With this change, NMConfig is really immutable and all
modifyable parts migrated to NMConfigData.

Another advantage is that components can now subscribe to
NMConfig changes to pickup changes to no-auto-default.
 2015-02-03 13:01:53 +01:00
Thomas Haller
49b3f5b8d9 config: refactor merging no_auto_default 2015-02-03 13:01:53 +01:00
Thomas Haller
ba74f9d242 config: move keyfile values to NMConfigData 2015-02-03 13:01:53 +01:00
Thomas Haller
045a576a7a config: add new function nm_config_data_diff() 2015-02-03 13:01:53 +01:00
Thomas Haller
56f5fba723 config: move main_file and description to NMConfigData 
Every reload might change the main_file and description.
Move those properties to NMConfigData.
 2015-02-03 13:01:53 +01:00