Thomas Haller
085a369446
all: avoid g_memdup()
...
By using nm_memdup().
Except in shared/nm-utils/nm-compat.c, which may not include
"shared/nm-utils/nm-shared-utils.h".
2018-09-07 11:24:17 +02:00
Thomas Haller
8342a66cb6
shared/compat: minor refactoring of compat code
...
Don't cache the entire GPtrArray, just the plain strv.
Also, use parentheses for sizeof().
2017-12-22 15:53:22 +01:00
Jan Alexander Steffens (heftig)
76207194d1
shared/compat: Fix memory handling of nm_setting_vpn_get_*_keys (v2)
...
The compat implementations return a (transfer none) strv instead of a
(transfer container) one. This has caused double frees in nm-applet:
https://bugs.archlinux.org/task/56772
We still need to copy the keys because nm_setting_vpn_foreach_* provides
us with copies that are freed after the iteration.
Fix this by handing out a duplicate of the array.
Fixes: 272439cb20https://mail.gnome.org/archives/networkmanager-list/2017-December/msg00070.html
2017-12-22 15:53:05 +01:00
Jan Alexander Steffens (heftig)
64fcfc62bb
Revert "shared/compat: fix memory handling of nm_setting_vpn_get_*_keys"
...
This reverts commit 8ac8c01162https://mail.gnome.org/archives/networkmanager-list/2017-December/msg00069.html
2017-12-22 15:52:41 +01:00
Jan Alexander Steffens (heftig)
8ac8c01162
shared/compat: fix memory handling of nm_setting_vpn_get_*_keys
...
The compat implementations return a (transfer none) strv instead of a
(transfer container) one. This has caused double frees in nm-applet:
https://bugs.archlinux.org/task/56772
Don't copy the keys and don't free the container later.
[thaller@redhat.com: patch adjusted to avoid compiler warning]
Fixes: 272439cb20
2017-12-21 09:51:10 +01:00
Thomas Haller
272439cb20
shared/compat: add compat for nm_setting_vpn_get_data_keys() and nm_setting_vpn_get_secret_keys()
2017-11-23 14:44:25 +01:00
Thomas Haller
1cb147663b
shared: add nm-utils/nm-compat.h
2017-11-23 14:44:25 +01:00
