Commit Graph

21088 Commits

Author SHA1 Message Date
Lubomir Rintel
4500968587 merge: branch 'lr/nmcli-overview-bgo766426'
https://bugzilla.gnome.org/show_bug.cgi?id=766426
2016-07-19 14:30:00 +02:00
Lubomir Rintel
f14845cc20 cli: output a short summary of devices when called without arguments
This aims to be somewhat similar to what "ifconfig" does.

https://bugzilla.gnome.org/show_bug.cgi?id=766426
2016-07-19 14:29:05 +02:00
Lubomir Rintel
402828d2ed cli/devices: export device_state_to_color()
Also, get rid of the ColorInfo structure. It was not too nice anyway.
2016-07-19 14:29:05 +02:00
Lubomir Rintel
65c6eb5ce5 cli/connections: split out ac_state_to_color()
Going to be useful outside nmcli c.
2016-07-19 14:29:05 +02:00
Jiří Klimeš
39930396cd merge: various syntax fixes for nmcli (bgo #768834) 2016-07-19 10:42:03 +02:00
Jiří Klimeš
58f7319043 man: additional fixes for nmcli commands syntax in nmcli.xml 2016-07-19 10:41:04 +02:00
Jiří Klimeš
77cb0e370e man: fix 'domain' to 'domains' for nmcli general logging 2016-07-15 12:26:24 +02:00
Jiří Klimeš
624a28504e man: fix 'nmcli connection edit' description in nmcli.xml 2016-07-15 12:26:24 +02:00
Jiří Klimeš
f99282d2f5 man: fix 'nmcli connection clone' description in nmcli.xml 2016-07-15 12:26:24 +02:00
Jiří Klimeš
6c71fd588f man: correct '--field' option in nmcli man page 2016-07-15 12:26:24 +02:00
Jiří Klimeš
250662a5d8 man: correct '--wait' option in nmcli man page 2016-07-15 12:26:24 +02:00
Jiří Klimeš
dfa26f2227 man: fix bridge-port properties description in nmcli.xml 2016-07-15 12:26:24 +02:00
Jiří Klimeš
e15645a4d0 man: add missing commands to 'nmcli connection' synopsis in nmcli.xml 2016-07-15 12:26:24 +02:00
Jiří Klimeš
2544f78858 nmcli: add missing commands to 'nmcli connection help' usage description 2016-07-15 12:26:24 +02:00
Jiří Klimeš
c875471430 nmcli: fix 'nmcli device modify' description
Fixes: 8b4494598d
2016-07-15 12:26:24 +02:00
Jiří Klimeš
887cdcc217 nmcli: remove the extra full stop from error messages
$ nmcli dev modify
Error: No interface specified..
$ nmcli dev modify bla
Error: Device 'bla' not found..
2016-07-15 11:43:32 +02:00
Lubomir Rintel
f9821a1669 dhcp: drop an unused fariable
Fixes: 1c58ce0d74
2016-07-13 12:26:15 +02:00
poma
846dc443ce doc: fix typo for cloned-mac-address documentation
https://mail.gnome.org/archives/networkmanager-list/2016-July/msg00006.html
2016-07-11 21:24:04 +02:00
Thomas Haller
d060958a6d libnm: minor cleanup of _bin2str() 2016-07-10 13:51:57 +02:00
Thomas Haller
36856ba610 all: reuse _nm_utils_hwaddr_ntoa() for converting binary to string 2016-07-10 13:44:58 +02:00
Thomas Haller
1c58ce0d74 dhcp: prefix logging messages with "dhcp" 2016-07-10 13:22:12 +02:00
Thomas Haller
bfe4a69c25 wwan: downgrade warning logging about 'No SIM object available'
On every start of NetworkManager I'd see a warning message:

  modem-broadband[cdc-wdm0]: failed to retrieve SIM object: No SIM object available

Apparently, to warn about this is too alarming.
2016-07-10 11:53:11 +02:00
Christian Kirbach
86ad508534 po: update German (de) translation (bgo #766927)
https://bugzilla.gnome.org/show_bug.cgi?id=766927
2016-07-10 10:57:26 +02:00
Beniamino Galvani
75406d1760 device: allow ipv6ll address to be set for disconnected devices
Commit f85941ee91 ("device: don't try to generate ipv6ll address for
disconnected devices") disabled the generation of IPv6 link-local
addresses for disconnected devices to fix a crash. However that broke
the following:

 $ ip a f dev eth0
 $ systemctl start NetworkManager
 $ nmcli d
 DEVICE  TYPE      STATE         CONNECTION
 eth0    ethernet  disconnected  eth0
 $ ip a a dev eth0 2001::42/64
 $ ip a show eth0
 4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP group default qlen 1000
     link/ether 52:52:00:61:32:81 brd ff:ff:ff:ff:ff:ff
     inet6 2001::42/64 scope global
        valid_lft forever preferred_lft forever
     (no link-local address)

Instead, enable the generation of a link-local address even if the
device is disconnected and fix nm_device_get_ip_iface_identifier() to
not require a connection if @ignore_token is set.

Fixes: f85941ee91
2016-07-09 11:38:58 +02:00
Thomas Haller
e988ed96f9 device: downgrade debug logging about not setting hardware address
No change is not particularly interesting, and for Wi-Fi devices
it happens everytime we scan. Downgrade the debug message to trace
level.
2016-07-09 10:23:39 +02:00
Beniamino Galvani
45484af2af platform: wifi: drop old wifi data when an interface is renamed
Drop the old wifi data when the interface is renamed, otherwise WEXT
methods would use the old name.

https://bugzilla.gnome.org/show_bug.cgi?id=768433
2016-07-08 13:40:10 +02:00
Thomas Haller
79c48a559f rdisc: merge branch 'th/rdisc-cleanup-bgo768521'
https://bugzilla.gnome.org/show_bug.cgi?id=768521
2016-07-08 12:35:29 +02:00
Thomas Haller
a9524509e8 rdisc: preserve most-managed dhcp-level from multiple router advertisements 2016-07-08 12:35:14 +02:00
Thomas Haller
0e07bbf968 rdisc: tighten up type and range of NMRDiscRoute.plen 2016-07-08 12:35:14 +02:00
Thomas Haller
15b486700f rdisc: hide internal fields from NMRDisc API
Hide the mutable fields that were exposed to the user of the NMRDisc API.
Instead, only expose a constant NMRDiscData structure.
2016-07-08 12:25:07 +02:00
Thomas Haller
c81eff0669 rdisc: move sysctl configuration values to NMRDiscPrivate
While at it, tighten up the integer values, types and ranges
and ensure no interger overflow can happen when calculating
timeouts and retry.
2016-07-08 12:25:07 +02:00
Thomas Haller
1bc3df0bd4 rdisc: move @iid field to NMRDiscPrivate 2016-07-08 12:08:55 +02:00
Thomas Haller
629332172b rdisc: refactor logging config-changes not as signal handler
Just log _config_changed_log() right away and not go through
the GObject signal.
2016-07-08 12:08:55 +02:00
Thomas Haller
db59f5fa11 rdisc: emit config-changed signal by ID and not by name
Also, properly cast the NMRDiscConfigMap argument to int.
2016-07-08 12:08:55 +02:00
Thomas Haller
d42b3aca60 rdisc: remove unused signal slots ra_timeout and ra_process 2016-07-08 12:08:55 +02:00
Thomas Haller
c9c00ec5c6 rdisc: move public fields from NMRDisc to NMRDiscPrivate
As they are initialized from the constructor of the subclass, the have
to be construct-only GObject properties, which brings some overhead.
2016-07-08 12:08:53 +02:00
Thomas Haller
322299617f rdisc: move @platform and @netns field to private structure NMRDiscPrivate 2016-07-08 12:08:02 +02:00
Thomas Haller
7ab03097fc rdisc: embed pointer to private data in NMRDisc
NMRDisc is one of the more heavily used classes. Let's clean it up
a bit.
2016-07-08 12:08:02 +02:00
Thomas Haller
5fa835baee rdisc/tests: don't link nm-fake-rdisc with non-testing NetworkManager binary 2016-07-08 12:08:02 +02:00
Thomas Haller
c5a72405b6 rdisc: hide NMLndpRDisc struct and embed private data 2016-07-08 12:08:02 +02:00
Thomas Haller
bb3f73655a rdisc/trivial: rename NMLNDPRDisc to NMLndpRDisc
For abbreviations that have more then 2 characters, we prefer to use lower-case.
For example, NMVpnManager.
2016-07-08 12:08:02 +02:00
Beniamino Galvani
10c5352855 secret-agent: increase timeout for GetSecrets D-Bus call
The default value of 25 seconds is too short, bump it to 120.

https://bugzilla.gnome.org/show_bug.cgi?id=767321
https://bugzilla.redhat.com/show_bug.cgi?id=1349740
2016-07-08 11:55:55 +02:00
Beniamino Galvani
0de2483685 merge: branch 'bg/team-conf-read-rh1257237'
https://bugzilla.redhat.com/show_bug.cgi?id=1257237
2016-07-07 17:31:37 +02:00
Beniamino Galvani
5d4fc4c9ac team: fail the connection if the teamd configuration can't be read
If the read of teamd configuration failed (possibly due to a timeout),
fail the connection immediately where possible instead of letting it
continue and risk to block again at the next read.

https://bugzilla.redhat.com/show_bug.cgi?id=1257237
2016-07-07 17:31:23 +02:00
Beniamino Galvani
06ded430e8 team: fix handling of D-Bus name watch events
When a device is activated any existing teamd instance is killed. But
since commit 28274495d6 ("device/team: always try to connect to
teamd in update_connection()") the disappearing of the D-Bus name
owner always triggers an automatic restart of the instance in
teamd_dbus_vanished() if the name was previously owned. This new
instance conflicts with the instance we're about to start.

Instead, restore the previous behavior of restarting teamd only if
there is an activation in progress and use @tdc as a flag. This also
means that update_connection() should not modify the value of @tdc.

Fixes: 28274495d6
2016-07-07 17:31:23 +02:00
Beniamino Galvani
22fc078a39 merge: branch 'bg/slave-activation-fail-rh1270814'
https://bugzilla.redhat.com/show_bug.cgi?id=1270814
2016-07-07 17:16:58 +02:00
Beniamino Galvani
3d8839927e policy: reset slaves' retry counter only for explicit activations
A infinite activation loop can arise when the master repeatedly fails
activating: slave's _internal_activate_device() calls
ensure_master_active_connection() to activate the master connection
and during master activation activate_slave_connections() resets the
retry counter of slaves.

The autoconnect retry counter of a slave should only be reset for
explicit master activations, not for auto-activations.

https://bugzilla.redhat.com/show_bug.cgi?id=1270814
2016-07-07 17:14:38 +02:00
Beniamino Galvani
adba47cb61 active-connection: don't weak-unref parent inside notify function 2016-07-07 17:14:38 +02:00
Beniamino Galvani
7f191eb15b device: fail slave activation if master is deactivating
When the master connection deactivates, we also fail slave
connections; but if the master deactivation happens just before a
slave reaches the PREPARE state, we failed to notice it and keep
the slave stuck without chance of progressing. Fix this.
2016-07-07 17:14:38 +02:00
Beniamino Galvani
f9feddbcf0 device: cancel pending activation when slave is released
Since nm_device_slave_notify_release() is called from outside the
activation chain of the slave device (it gets called from the master
device) there might be pending activation sources scheduled, clear
them before queueing a state change.
2016-07-07 17:14:38 +02:00