From 0c40f3562387f4061ad6463a83c6b86614ea38b8 Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Thu, 29 Mar 2018 13:12:18 -0400 Subject: [PATCH] Document disadvantage of fetching messages without index --- js/modules/messages_data_migrator.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/modules/messages_data_migrator.js b/js/modules/messages_data_migrator.js index 43730020b..1e2a5b309 100644 --- a/js/modules/messages_data_migrator.js +++ b/js/modules/messages_data_migrator.js @@ -238,6 +238,8 @@ const _fetchMessagesRequiringSchemaUpgrade = })); }; +// NOTE: Named ‘dangerous’ because it is not as efficient as using our +// `messages` `schemaVersion` index: const _dangerouslyFetchMessagesRequiringSchemaUpgradeWithoutIndex = ({ connection, count, lastIndex } = {}) => { if (!isObject(connection)) {