From 14b42f0f11218fac1544e878ee82ea2d8eedaf4c Mon Sep 17 00:00:00 2001 From: Evan Hahn <69474926+EvanHahn-Signal@users.noreply.github.com> Date: Thu, 30 Sep 2021 11:37:55 -0500 Subject: [PATCH] Remove unused "inactive" class from inbox view --- ts/util/lint/exceptions.json | 42 ------------------------------------ ts/views/inbox_view.ts | 9 -------- 2 files changed, 51 deletions(-) diff --git a/ts/util/lint/exceptions.json b/ts/util/lint/exceptions.json index 20e3d6071..bb6fa9fb4 100644 --- a/ts/util/lint/exceptions.json +++ b/ts/util/lint/exceptions.json @@ -13530,27 +13530,6 @@ "reasonCategory": "usageTrusted", "updated": "2021-09-15T21:07:50.995Z" }, - { - "rule": "jQuery-$(", - "path": "ts/views/inbox_view.js", - "line": " if (e && this.$(e.target).closest('.placeholder').length) {", - "reasonCategory": "usageTrusted", - "updated": "2021-09-15T21:07:50.995Z" - }, - { - "rule": "jQuery-$(", - "path": "ts/views/inbox_view.js", - "line": " this.$('#header, .gutter').addClass('inactive');", - "reasonCategory": "usageTrusted", - "updated": "2021-09-15T21:07:50.995Z" - }, - { - "rule": "jQuery-$(", - "path": "ts/views/inbox_view.js", - "line": " this.$('.conversation-stack').removeClass('inactive');", - "reasonCategory": "usageTrusted", - "updated": "2021-09-15T21:07:50.995Z" - }, { "rule": "jQuery-$(", "path": "ts/views/inbox_view.js", @@ -13649,27 +13628,6 @@ "reasonCategory": "usageTrusted", "updated": "2021-09-15T21:07:50.995Z" }, - { - "rule": "jQuery-$(", - "path": "ts/views/inbox_view.ts", - "line": " if (e && this.$(e.target).closest('.placeholder').length) {", - "reasonCategory": "usageTrusted", - "updated": "2021-09-15T21:07:50.995Z" - }, - { - "rule": "jQuery-$(", - "path": "ts/views/inbox_view.ts", - "line": " this.$('#header, .gutter').addClass('inactive');", - "reasonCategory": "usageTrusted", - "updated": "2021-09-15T21:07:50.995Z" - }, - { - "rule": "jQuery-$(", - "path": "ts/views/inbox_view.ts", - "line": " this.$('.conversation-stack').removeClass('inactive');", - "reasonCategory": "usageTrusted", - "updated": "2021-09-15T21:07:50.995Z" - }, { "rule": "jQuery-$(", "path": "ts/views/inbox_view.ts", diff --git a/ts/views/inbox_view.ts b/ts/views/inbox_view.ts index 18f6e4a43..a0e24f8b7 100644 --- a/ts/views/inbox_view.ts +++ b/ts/views/inbox_view.ts @@ -115,7 +115,6 @@ Whisper.InboxView = Whisper.View.extend({ } this.conversation_stack.open(conversation, messageId); - this.focusConversation(); }); window.Whisper.events.on('showSafetyNumberInConversation', id => { @@ -217,14 +216,6 @@ Whisper.InboxView = Whisper.View.extend({ searchInput?.focus?.(); } }, - focusConversation(e: MouseEvent) { - if (e && this.$(e.target).closest('.placeholder').length) { - return; - } - - this.$('#header, .gutter').addClass('inactive'); - this.$('.conversation-stack').removeClass('inactive'); - }, closeRecording(e: MouseEvent) { if (e && this.$(e.target).closest('.capture-audio').length > 0) { return;