colin/Signal-Desktop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move menu tests to TypeScript

Browse Source
This commit is contained in:
Evan Hahn
2022-01-11 11:28:04 -06:00
committed by GitHub
parent a014337e72
commit 206f461370
9 changed files with 273 additions and 1180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

160
test/app/fixtures/menu-linux-setup.json
View File

@@ -1,160 +0,0 @@
[
{
"label": "&File",
"submenu": [
{
"label": "Set Up as New Device",
"click": null
},
{
"type": "separator"
},
{
"label": "Create/upload sticker pack",
"click": null
},
{
"accelerator": "CommandOrControl+,",
"label": "Preferences…",
"click": null
},
{
"type": "separator"
},
{
"label": "Quit Signal",
"role": "quit"
}
]
},
{
"label": "&Edit",
"submenu": [
{
"label": "Undo",
"role": "undo"
},
{
"label": "Redo",
"role": "redo"
},
{
"type": "separator"
},
{
"label": "Cut",
"role": "cut"
},
{
"label": "Copy",
"role": "copy"
},
{
"label": "Paste",
"role": "paste"
},
{
"label": "Paste and Match Style",
"role": "pasteAndMatchStyle"
},
{
"label": "Delete",
"role": "delete"
},
{
"label": "Select All",
"role": "selectAll"
}
]
},
{
"label": "&View",
"submenu": [
{
"label": "Actual Size",
"role": "resetZoom"
},
{
"accelerator": "Control+=",
"label": "Zoom In",
"role": "zoomIn"
},
{
"label": "Zoom Out",
"role": "zoomOut"
},
{
"type": "separator"
},
{
"label": "Toggle Full Screen",
"role": "togglefullscreen"
},
{
"type": "separator"
},
{
"label": "Debug Log",
"click": null
},
{
"type": "separator"
},
{
"label": "Toggle Developer Tools",
"role": "toggleDevTools"
}
]
},
{
"label": "&Window",
"role": "window",
"submenu": [
{
"label": "Minimize",
"role": "minimize"
}
]
},
{
"label": "&Help",
"role": "help",
"submenu": [
{
"label": "Show Keyboard Shortcuts",
"accelerator": "CmdOrCtrl+/",
"click": null
},
{
"type": "separator"
},
{
"label": "Contact Us",
"click": null
},
{
"label": "Go to Release Notes",
"click": null
},
{
"label": "Go to Forums",
"click": null
},
{
"label": "Go to Support Page",
"click": null
},
{
"label": "Join the Beta",
"click": null
},
{
"type": "separator"
},
{
"label": "About Signal Desktop",
"click": null
}
]
}
]

153
test/app/fixtures/menu-linux.json
View File

@@ -1,153 +0,0 @@
[
{
"label": "&File",
"submenu": [
{
"label": "Create/upload sticker pack",
"click": null
},
{
"accelerator": "CommandOrControl+,",
"label": "Preferences…",
"click": null
},
{
"type": "separator"
},
{
"label": "Quit Signal",
"role": "quit"
}
]
},
{
"label": "&Edit",
"submenu": [
{
"label": "Undo",
"role": "undo"
},
{
"label": "Redo",
"role": "redo"
},
{
"type": "separator"
},
{
"label": "Cut",
"role": "cut"
},
{
"label": "Copy",
"role": "copy"
},
{
"label": "Paste",
"role": "paste"
},
{
"label": "Paste and Match Style",
"role": "pasteAndMatchStyle"
},
{
"label": "Delete",
"role": "delete"
},
{
"label": "Select All",
"role": "selectAll"
}
]
},
{
"label": "&View",
"submenu": [
{
"label": "Actual Size",
"role": "resetZoom"
},
{
"accelerator": "Control+=",
"label": "Zoom In",
"role": "zoomIn"
},
{
"label": "Zoom Out",
"role": "zoomOut"
},
{
"type": "separator"
},
{
"label": "Toggle Full Screen",
"role": "togglefullscreen"
},
{
"type": "separator"
},
{
"label": "Debug Log",
"click": null
},
{
"type": "separator"
},
{
"label": "Toggle Developer Tools",
"role": "toggleDevTools"
}
]
},
{
"label": "&Window",
"role": "window",
"submenu": [
{
"label": "Minimize",
"role": "minimize"
}
]
},
{
"label": "&Help",
"role": "help",
"submenu": [
{
"label": "Show Keyboard Shortcuts",
"accelerator": "CmdOrCtrl+/",
"click": null
},
{
"type": "separator"
},
{
"label": "Contact Us",
"click": null
},
{
"label": "Go to Release Notes",
"click": null
},
{
"label": "Go to Forums",
"click": null
},
{
"label": "Go to Support Page",
"click": null
},
{
"label": "Join the Beta",
"click": null
},
{
"type": "separator"
},
{
"label": "About Signal Desktop",
"click": null
}
]
}
]

232
test/app/fixtures/menu-mac-os-setup.json
View File

@@ -1,232 +0,0 @@
[
{
"label": "Signal Desktop",
"submenu": [
{
"label": "About Signal Desktop",
"click": null
},
{
"type": "separator"
},
{
"label": "Preferences…",
"accelerator": "CommandOrControl+,",
"click": null
},
{
"type": "separator"
},
{
"label": "Services",
"role": "services"
},
{
"type": "separator"
},
{
"label": "Hide",
"role": "hide"
},
{
"label": "Hide Others",
"role": "hideOthers"
},
{
"label": "Show All",
"role": "unhide"
},
{
"type": "separator"
},
{
"label": "Quit Signal",
"role": "quit"
}
]
},
{
"label": "&File",
"submenu": [
{
"label": "Set Up as New Device",
"click": null
},
{
"type": "separator"
},
{
"label": "Create/upload sticker pack",
"click": null
},
{
"type": "separator"
},
{
"accelerator": "CmdOrCtrl+W",
"label": "Close Window",
"role": "close"
}
]
},
{
"label": "&Edit",
"submenu": [
{
"label": "Undo",
"role": "undo"
},
{
"label": "Redo",
"role": "redo"
},
{
"type": "separator"
},
{
"label": "Cut",
"role": "cut"
},
{
"label": "Copy",
"role": "copy"
},
{
"label": "Paste",
"role": "paste"
},
{
"label": "Paste and Match Style",
"role": "pasteAndMatchStyle"
},
{
"label": "Delete",
"role": "delete"
},
{
"label": "Select All",
"role": "selectAll"
},
{
"type": "separator"
},
{
"label": "Speech",
"submenu": [
{
"label": "Start speaking",
"role": "startSpeaking"
},
{
"label": "Stop speaking",
"role": "stopSpeaking"
}
]
}
]
},
{
"label": "&View",
"submenu": [
{
"label": "Actual Size",
"role": "resetZoom"
},
{
"accelerator": "Command+=",
"label": "Zoom In",
"role": "zoomIn"
},
{
"label": "Zoom Out",
"role": "zoomOut"
},
{
"type": "separator"
},
{
"label": "Toggle Full Screen",
"role": "togglefullscreen"
},
{
"type": "separator"
},
{
"label": "Debug Log",
"click": null
},
{
"type": "separator"
},
{
"label": "Toggle Developer Tools",
"role": "toggleDevTools"
},
{
"label": "Force Update",
"click": null
}
]
},
{
"label": "&Window",
"role": "window",
"submenu": [
{
"label": "Minimize",
"accelerator": "CmdOrCtrl+M",
"role": "minimize"
},
{
"label": "Zoom",
"role": "zoom"
},
{
"label": "Show",
"accelerator": "CmdOrCtrl+Shift+0",
"click": null
},
{
"type": "separator"
},
{
"label": "Bring All to Front",
"role": "front"
}
]
},
{
"label": "&Help",
"role": "help",
"submenu": [
{
"label": "Show Keyboard Shortcuts",
"accelerator": "CmdOrCtrl+/",
"click": null
},
{
"type": "separator"
},
{
"label": "Contact Us",
"click": null
},
{
"label": "Go to Release Notes",
"click": null
},
{
"label": "Go to Forums",
"click": null
},
{
"label": "Go to Support Page",
"click": null
},
{
"label": "Join the Beta",
"click": null
}
]
}
]

225
test/app/fixtures/menu-mac-os.json
View File

@@ -1,225 +0,0 @@
[
{
"label": "Signal Desktop",
"submenu": [
{
"label": "About Signal Desktop",
"click": null
},
{
"type": "separator"
},
{
"label": "Preferences…",
"accelerator": "CommandOrControl+,",
"click": null
},
{
"type": "separator"
},
{
"label": "Services",
"role": "services"
},
{
"type": "separator"
},
{
"label": "Hide",
"role": "hide"
},
{
"label": "Hide Others",
"role": "hideOthers"
},
{
"label": "Show All",
"role": "unhide"
},
{
"type": "separator"
},
{
"label": "Quit Signal",
"role": "quit"
}
]
},
{
"label": "&File",
"submenu": [
{
"label": "Create/upload sticker pack",
"click": null
},
{
"type": "separator"
},
{
"accelerator": "CmdOrCtrl+W",
"label": "Close Window",
"role": "close"
}
]
},
{
"label": "&Edit",
"submenu": [
{
"label": "Undo",
"role": "undo"
},
{
"label": "Redo",
"role": "redo"
},
{
"type": "separator"
},
{
"label": "Cut",
"role": "cut"
},
{
"label": "Copy",
"role": "copy"
},
{
"label": "Paste",
"role": "paste"
},
{
"label": "Paste and Match Style",
"role": "pasteAndMatchStyle"
},
{
"label": "Delete",
"role": "delete"
},
{
"label": "Select All",
"role": "selectAll"
},
{
"type": "separator"
},
{
"label": "Speech",
"submenu": [
{
"label": "Start speaking",
"role": "startSpeaking"
},
{
"label": "Stop speaking",
"role": "stopSpeaking"
}
]
}
]
},
{
"label": "&View",
"submenu": [
{
"label": "Actual Size",
"role": "resetZoom"
},
{
"accelerator": "Command+=",
"label": "Zoom In",
"role": "zoomIn"
},
{
"label": "Zoom Out",
"role": "zoomOut"
},
{
"type": "separator"
},
{
"label": "Toggle Full Screen",
"role": "togglefullscreen"
},
{
"type": "separator"
},
{
"label": "Debug Log",
"click": null
},
{
"type": "separator"
},
{
"label": "Toggle Developer Tools",
"role": "toggleDevTools"
},
{
"label": "Force Update",
"click": null
}
]
},
{
"label": "&Window",
"role": "window",
"submenu": [
{
"label": "Minimize",
"accelerator": "CmdOrCtrl+M",
"role": "minimize"
},
{
"label": "Zoom",
"role": "zoom"
},
{
"label": "Show",
"accelerator": "CmdOrCtrl+Shift+0",
"click": null
},
{
"type": "separator"
},
{
"label": "Bring All to Front",
"role": "front"
}
]
},
{
"label": "&Help",
"role": "help",
"submenu": [
{
"label": "Show Keyboard Shortcuts",
"accelerator": "CmdOrCtrl+/",
"click": null
},
{
"type": "separator"
},
{
"label": "Contact Us",
"click": null
},
{
"label": "Go to Release Notes",
"click": null
},
{
"label": "Go to Forums",
"click": null
},
{
"label": "Go to Support Page",
"click": null
},
{
"label": "Join the Beta",
"click": null
}
]
}
]

164
test/app/fixtures/menu-windows-setup.json
View File

@@ -1,164 +0,0 @@
[
{
"label": "&File",
"submenu": [
{
"label": "Set Up as New Device",
"click": null
},
{
"type": "separator"
},
{
"label": "Create/upload sticker pack",
"click": null
},
{
"accelerator": "CommandOrControl+,",
"label": "Preferences…",
"click": null
},
{
"type": "separator"
},
{
"label": "Quit Signal",
"role": "quit"
}
]
},
{
"label": "&Edit",
"submenu": [
{
"label": "Undo",
"role": "undo"
},
{
"label": "Redo",
"role": "redo"
},
{
"type": "separator"
},
{
"label": "Cut",
"role": "cut"
},
{
"label": "Copy",
"role": "copy"
},
{
"label": "Paste",
"role": "paste"
},
{
"label": "Paste and Match Style",
"role": "pasteAndMatchStyle"
},
{
"label": "Delete",
"role": "delete"
},
{
"label": "Select All",
"role": "selectAll"
}
]
},
{
"label": "&View",
"submenu": [
{
"label": "Actual Size",
"role": "resetZoom"
},
{
"accelerator": "Control+=",
"label": "Zoom In",
"role": "zoomIn"
},
{
"label": "Zoom Out",
"role": "zoomOut"
},
{
"type": "separator"
},
{
"label": "Toggle Full Screen",
"role": "togglefullscreen"
},
{
"type": "separator"
},
{
"label": "Debug Log",
"click": null
},
{
"type": "separator"
},
{
"label": "Toggle Developer Tools",
"role": "toggleDevTools"
},
{
"label": "Force Update",
"click": null
}
]
},
{
"label": "&Window",
"role": "window",
"submenu": [
{
"label": "Minimize",
"role": "minimize"
}
]
},
{
"label": "&Help",
"role": "help",
"submenu": [
{
"label": "Show Keyboard Shortcuts",
"accelerator": "CmdOrCtrl+/",
"click": null
},
{
"type": "separator"
},
{
"label": "Contact Us",
"click": null
},
{
"label": "Go to Release Notes",
"click": null
},
{
"label": "Go to Forums",
"click": null
},
{
"label": "Go to Support Page",
"click": null
},
{
"label": "Join the Beta",
"click": null
},
{
"type": "separator"
},
{
"label": "About Signal Desktop",
"click": null
}
]
}
]

157
test/app/fixtures/menu-windows.json
View File

@@ -1,157 +0,0 @@
[
{
"label": "&File",
"submenu": [
{
"label": "Create/upload sticker pack",
"click": null
},
{
"accelerator": "CommandOrControl+,",
"label": "Preferences…",
"click": null
},
{
"type": "separator"
},
{
"label": "Quit Signal",
"role": "quit"
}
]
},
{
"label": "&Edit",
"submenu": [
{
"label": "Undo",
"role": "undo"
},
{
"label": "Redo",
"role": "redo"
},
{
"type": "separator"
},
{
"label": "Cut",
"role": "cut"
},
{
"label": "Copy",
"role": "copy"
},
{
"label": "Paste",
"role": "paste"
},
{
"label": "Paste and Match Style",
"role": "pasteAndMatchStyle"
},
{
"label": "Delete",
"role": "delete"
},
{
"label": "Select All",
"role": "selectAll"
}
]
},
{
"label": "&View",
"submenu": [
{
"label": "Actual Size",
"role": "resetZoom"
},
{
"accelerator": "Control+=",
"label": "Zoom In",
"role": "zoomIn"
},
{
"label": "Zoom Out",
"role": "zoomOut"
},
{
"type": "separator"
},
{
"label": "Toggle Full Screen",
"role": "togglefullscreen"
},
{
"type": "separator"
},
{
"label": "Debug Log",
"click": null
},
{
"type": "separator"
},
{
"label": "Toggle Developer Tools",
"role": "toggleDevTools"
},
{
"label": "Force Update",
"click": null
}
]
},
{
"label": "&Window",
"role": "window",
"submenu": [
{
"label": "Minimize",
"role": "minimize"
}
]
},
{
"label": "&Help",
"role": "help",
"submenu": [
{
"label": "Show Keyboard Shortcuts",
"accelerator": "CmdOrCtrl+/",
"click": null
},
{
"type": "separator"
},
{
"label": "Contact Us",
"click": null
},
{
"label": "Go to Release Notes",
"click": null
},
{
"label": "Go to Forums",
"click": null
},
{
"label": "Go to Support Page",
"click": null
},
{
"label": "Join the Beta",
"click": null
},
{
"type": "separator"
},
{
"label": "About Signal Desktop",
"click": null
}
]
}
]

87
test/app/menu_test.js
View File

@@ -1,87 +0,0 @@
// Copyright 2018-2020 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
const { assert } = require('chai');
const SignalMenu = require('../../app/menu');
const { load: loadLocale } = require('../../app/locale');
const PLATFORMS = [
{
label: 'macOS',
platform: 'darwin',
fixtures: {
default: './fixtures/menu-mac-os',
setup: './fixtures/menu-mac-os-setup',
},
},
{
label: 'Windows',
platform: 'win32',
fixtures: {
default: './fixtures/menu-windows',
setup: './fixtures/menu-windows-setup',
},
},
{
label: 'Linux',
platform: 'linux',
fixtures: {
default: './fixtures/menu-linux',
setup: './fixtures/menu-linux-setup',
},
},
];
const INCLUDE_SETUP_OPTIONS = [false, true];
describe('SignalMenu', () => {
describe('createTemplate', () => {
PLATFORMS.forEach(({ label, platform, fixtures }) => {
context(label, () => {
INCLUDE_SETUP_OPTIONS.forEach(includeSetup => {
const prefix = includeSetup ? 'with' : 'without';
context(`${prefix} setup options`, () => {
it('should return correct template', () => {
const logger = {
error(message) {
throw new Error(message);
},
};
const options = {
isProduction: true,
devTools: true,
openContactUs: null,
openForums: null,
openJoinTheBeta: null,
openReleaseNotes: null,
openSupportPage: null,
platform,
includeSetup,
setupAsNewDevice: null,
setupAsStandalone: null,
forceUpdate: null,
showAbout: null,
showDebugLog: null,
showKeyboardShortcuts: null,
showSettings: null,
showStickerCreator: null,
showWindow: null,
};
const appLocale = 'en';
const { messages } = loadLocale({ appLocale, logger });
const actual = SignalMenu.createTemplate(options, messages);
const fixturePath = includeSetup
? fixtures.setup
: fixtures.default;
// eslint-disable-next-line global-require, import/no-dynamic-require
const fixture = require(fixturePath);
assert.deepEqual(actual, fixture);
});
});
});
});
});
});
});