Save modified messages for edits

Co-authored-by: Josh Perez <josh.p@signal.org>

ts/models/messages.ts

@@ -2367,7 +2367,6 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
     return modifyTargetMessage(this, conversation, {
       isFirstRun,
       skipEdits: false,
-      skipSave: false,
     });
   }
 

ts/util/handleEditMessage.ts

@@ -342,7 +342,6 @@ export async function handleEditMessage(
     await modifyTargetMessage(mainMessageModel, mainMessageConversation, {
       isFirstRun: false,
       skipEdits: true,
-      skipSave: true,
     });
   }
 

ts/util/modifyTargetMessage.ts

@@ -35,13 +35,9 @@ import { strictAssert } from './assert';
 export async function modifyTargetMessage(
   message: MessageModel,
   conversation: ConversationModel,
-  options?: { isFirstRun: boolean; skipEdits: boolean; skipSave: boolean }
+  options?: { isFirstRun: boolean; skipEdits: boolean }
 ): Promise<void> {
-  const {
+  const { isFirstRun = false, skipEdits = false } = options ?? {};
-    isFirstRun = false,
-    skipEdits = false,
-    skipSave = false,
-  } = options ?? {};
 
   const logId = `modifyTargetMessage/${message.idForLogging()}`;
   const type = message.get('type');
@@ -267,7 +263,7 @@ export async function modifyTargetMessage(
     );
   }
 
-  if (!skipSave && changed && !isFirstRun) {
+  if (changed && !isFirstRun) {
     log.info(`${logId}: Changes in second run; saving.`);
     await window.Signal.Data.saveMessage(message.attributes, {
       ourAci,