Use Promise.reject for simplicity
The following are equivalent, except that the first is longer and invokes an extra function call. ``` return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); }); return Promise.reject(new Error("Unknown Group")); ```
This commit is contained in:
@@ -40074,7 +40074,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
|
|
||||||
var promises = [];
|
var promises = [];
|
||||||
for (var i in attachments)
|
for (var i in attachments)
|
||||||
@@ -40123,7 +40123,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.addNumbers(groupId, numbers).then(function(numbers) {
|
return textsecure.storage.groups.addNumbers(groupId, numbers).then(function(numbers) {
|
||||||
if (numbers === undefined) {
|
if (numbers === undefined) {
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
}
|
}
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
@@ -40150,7 +40150,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.addNumbers(groupId, [number]).then(function(numbers) {
|
return textsecure.storage.groups.addNumbers(groupId, [number]).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
return sendGroupProto(numbers, proto);
|
return sendGroupProto(numbers, proto);
|
||||||
@@ -40166,7 +40166,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
return sendGroupProto(numbers, proto);
|
return sendGroupProto(numbers, proto);
|
||||||
@@ -40181,7 +40181,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
return makeAttachmentPointer(avatar).then(function(attachment) {
|
return makeAttachmentPointer(avatar).then(function(attachment) {
|
||||||
@@ -40199,7 +40199,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
return textsecure.storage.groups.deleteGroup(groupId).then(function() {
|
return textsecure.storage.groups.deleteGroup(groupId).then(function() {
|
||||||
return sendGroupProto(numbers, proto);
|
return sendGroupProto(numbers, proto);
|
||||||
});
|
});
|
||||||
|
@@ -379,7 +379,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
|
|
||||||
var promises = [];
|
var promises = [];
|
||||||
for (var i in attachments)
|
for (var i in attachments)
|
||||||
@@ -428,7 +428,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.addNumbers(groupId, numbers).then(function(numbers) {
|
return textsecure.storage.groups.addNumbers(groupId, numbers).then(function(numbers) {
|
||||||
if (numbers === undefined) {
|
if (numbers === undefined) {
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
}
|
}
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
@@ -455,7 +455,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.addNumbers(groupId, [number]).then(function(numbers) {
|
return textsecure.storage.groups.addNumbers(groupId, [number]).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
return sendGroupProto(numbers, proto);
|
return sendGroupProto(numbers, proto);
|
||||||
@@ -471,7 +471,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
return sendGroupProto(numbers, proto);
|
return sendGroupProto(numbers, proto);
|
||||||
@@ -486,7 +486,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
proto.group.members = numbers;
|
proto.group.members = numbers;
|
||||||
|
|
||||||
return makeAttachmentPointer(avatar).then(function(attachment) {
|
return makeAttachmentPointer(avatar).then(function(attachment) {
|
||||||
@@ -504,7 +504,7 @@ window.textsecure.messaging = function() {
|
|||||||
|
|
||||||
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
return textsecure.storage.groups.getNumbers(groupId).then(function(numbers) {
|
||||||
if (numbers === undefined)
|
if (numbers === undefined)
|
||||||
return new Promise(function(resolve, reject) { reject(new Error("Unknown Group")); });
|
return Promise.reject(new Error("Unknown Group"));
|
||||||
return textsecure.storage.groups.deleteGroup(groupId).then(function() {
|
return textsecure.storage.groups.deleteGroup(groupId).then(function() {
|
||||||
return sendGroupProto(numbers, proto);
|
return sendGroupProto(numbers, proto);
|
||||||
});
|
});
|
||||||
|
Reference in New Issue
Block a user