From ca6f7471f15955a918aeeffba4fbca75470f6d27 Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Tue, 20 Aug 2019 09:59:17 -0700 Subject: [PATCH] Remove all calls to flashFrame() --- js/notifications.js | 3 --- main.js | 14 -------------- preload.js | 4 ---- 3 files changed, 21 deletions(-) diff --git a/js/notifications.js b/js/notifications.js index 7c0fb39ae..d6b673481 100644 --- a/js/notifications.js +++ b/js/notifications.js @@ -1,7 +1,6 @@ /* global Signal:false */ /* global Backbone: false */ -/* global drawAttention: false */ /* global i18n: false */ /* global isFocused: false */ /* global Signal: false */ @@ -136,8 +135,6 @@ message = i18n('newMessage'); } - drawAttention(); - this.lastNotification = new Notification(title, { body: window.platform === 'linux' ? filter(message) : message, icon: iconUrl, diff --git a/main.js b/main.js index beee967e4..7061105b2 100644 --- a/main.js +++ b/main.js @@ -313,10 +313,6 @@ function createWindow() { mainWindow.on('resize', debouncedCaptureStats); mainWindow.on('move', debouncedCaptureStats); - mainWindow.on('focus', () => { - mainWindow.flashFrame(false); - }); - // Ingested in preload.js via a sendSync call ipc.on('locale-data', event => { // eslint-disable-next-line no-param-reassign @@ -894,16 +890,6 @@ ipc.on('add-setup-menu-items', () => { }); }); -ipc.on('draw-attention', () => { - if (process.platform === 'darwin') { - app.dock.bounce(); - } else if (process.platform === 'win32') { - mainWindow.flashFrame(true); - } else if (process.platform === 'linux') { - mainWindow.flashFrame(true); - } -}); - ipc.on('restart', () => { app.relaunch(); app.quit(); diff --git a/preload.js b/preload.js index 369fb10ca..be832ebc6 100644 --- a/preload.js +++ b/preload.js @@ -90,10 +90,6 @@ window.open = () => null; // eslint-disable-next-line no-eval, no-multi-assign window.eval = global.eval = () => null; -window.drawAttention = () => { - window.log.info('draw attention'); - ipc.send('draw-attention'); -}; window.showWindow = () => { window.log.info('show window'); ipc.send('show-window');