From 5a036343d39cc5da3b08c3f2fc1ff249983f7dab Mon Sep 17 00:00:00 2001 From: Maxim Baz Date: Sun, 14 Apr 2019 23:49:21 +0200 Subject: [PATCH] Use getAttribute to safely read attribute value (#110) --- src/inject.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/inject.js b/src/inject.js index c9b3435..afe33ac 100644 --- a/src/inject.js +++ b/src/inject.js @@ -319,10 +319,11 @@ // Try to filter only forms that have some identifying marker const markedForms = []; for (let form of forms) { - const props = [form.id, form.name, form.className, form.action]; + const props = ["id", "name", "class", "action"]; for (let marker of FORM_MARKERS) { for (let prop of props) { - if (prop.toLowerCase().indexOf(marker) > -1) { + let propValue = form.getAttribute(prop) || ""; + if (propValue.toLowerCase().indexOf(marker) > -1) { markedForms.push(form); } }